Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable "Substrate Dev" netwok in Dev mode #417

Merged
merged 3 commits into from
Oct 18, 2019
Merged

chore: Enable "Substrate Dev" netwok in Dev mode #417

merged 3 commits into from
Oct 18, 2019

Conversation

Kriyszig
Copy link
Contributor

Issue in focus: #402

In case any changes are required, please let me know and I'll address them ASAP!

@parity-cla-bot
Copy link

It looks like @Kriyszig hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@Kriyszig
Copy link
Contributor Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @Kriyszig signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

* Removed in #384, this brings back the Substrate Dev network when
__DEV__ is active
@Kriyszig Kriyszig changed the title Enable "Substrate Dev" netwok in Dev mode chore: Enable "Substrate Dev" netwok in Dev mode Oct 14, 2019
@Tbaut
Copy link
Contributor

Tbaut commented Oct 14, 2019

Thanks for tackling this. It needs a little more than this if we want things to work.
There is also the need for adding the static-substrate.js because it's been deleted here https://github.com/paritytech/parity-signer/pull/384/files

Also as explained in the issue, the "Substrate Dev" should be shown in the Network chooser when we are in Dev.

Finally, the "Substrate Dev" Network should be uncommented in constants.js

* Brought back static-substrate.js
* Added Substrate Dev in menu option
* Uncommented relavent fields in constants.js
@Kriyszig
Copy link
Contributor Author

@Tbaut Made the necessary changes in the latest commit. Out if the commented lines I have replaced const isSubstrateDev = this.props.prefix === SUBSTRATE_NETWORK_LIST[SubstrateNetworkKeys.SUBSTRATE_DEV].prefix; with just __DEV__ to detect the Dev environment, should I revert that?

Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small grumbles, we're getting close :)

src/components/PayloadDetailsCard.js Outdated Show resolved Hide resolved
src/components/PayloadDetailsCard.js Show resolved Hide resolved
src/constants.js Show resolved Hide resolved
Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I've tested it with polkadot-js and it works well.

@Tbaut Tbaut merged commit 0efc12c into novasamatech:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants