-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enable "Substrate Dev" netwok in Dev mode #417
Conversation
It looks like @Kriyszig hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
[clabot:check] |
It looks like @Kriyszig signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
* Removed in #384, this brings back the Substrate Dev network when __DEV__ is active
Thanks for tackling this. It needs a little more than this if we want things to work. Also as explained in the issue, the "Substrate Dev" should be shown in the Network chooser when we are in Dev. Finally, the "Substrate Dev" Network should be uncommented in |
* Brought back static-substrate.js * Added Substrate Dev in menu option * Uncommented relavent fields in constants.js
@Tbaut Made the necessary changes in the latest commit. Out if the commented lines I have replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small grumbles, we're getting close :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, I've tested it with polkadot-js and it works well.
Issue in focus: #402
__DEV__
is activeIn case any changes are required, please let me know and I'll address them ASAP!