chore: Use Kusama cc2 genesis hash #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tbaut
commented
Sep 30, 2019
hanwencheng
reviewed
Sep 30, 2019
| @@ -27,7 +27,7 @@ const substrateNetworkBase = { | |||
| decimals: 12, | |||
| genesisHash: SubstrateNetworkKeys.KUSAMA, | |||
| prefix: 2, | |||
| title: 'Kusama', | |||
| title: 'Kusama CC2', | |||
There was a problem hiding this comment.
Anything you’ve done on Kusama so far will persist into Kusama CC2
See this from the CC2 release post, correct me if I am wrong, we can still use name Kusama, since currently all the users on Kusama use the same network.
There was a problem hiding this comment.
We can still use the name Kusama, but if there's a CC3 in the future, with a different genesis hash, and we only write "Kusama", things may be confusing, I think it's better to be precise.
If there's a Kusama CC3, any account created with CC2 will need to be migrated (manually or automatically).
hanwencheng
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"0xe3777fa922cafbff200cadeaea1a76bd7898ad5b89f7848999058b50e715f636"
Tested with apps, could sign the tx, got "error 1010", as expected since transfer aren't enabled.