Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR Code Scanner Fixes #332

Merged
merged 5 commits into from
Aug 27, 2019
Merged

QR Code Scanner Fixes #332

merged 5 commits into from
Aug 27, 2019

Conversation

hanwencheng
Copy link
Contributor

fix #247

mainly 3 fixes:

a15259d: fix a scanning user UX issue, after unavailable QR code, only trigger the scan when the user clicks the button.

out mp4

b5e239f: add address detected warning.

eaf9f52: remove an unhandled promise rejection warning, code should return when error detected.

@hanwencheng hanwencheng changed the title Hanwen QR Code Scanner Fixes QR Code Scanner Fixes Aug 26, 2019
src/util/decoders.js Outdated Show resolved Hide resolved
src/util/decoders.js Outdated Show resolved Hide resolved
src/util/decoders.js Outdated Show resolved Hide resolved
}
var hex = hexBytes.toString();
var str = '';
for (var n = 0; n < hex.length; n += 2) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (var n = 0; n < hex.length; n += 2) {
for (let n = 0; n < hex.length; n += 2) {

src/screens/QrScanner.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR.
Unrelated side note: We really need to add a linter to this project. The ton of nits and whitespace modifications totally dilute the real changes or the PR. I'll give it a play on my android now.

@hanwencheng
Copy link
Contributor Author

@Tbaut I agree, before I make the commit, I just do prettier --write with the file. It would be nice if we have a lint standard and to integrate the lint into CI test.

Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works well. I tested with Ethereum and Substrate addresses.
Signing still works (tested on Ethereum)

@pmespresso
Copy link
Contributor

works well on iOS! thank you!

@Tbaut Tbaut merged commit cbfbd32 into master Aug 27, 2019
@Tbaut Tbaut deleted the hanwen-address-message branch August 27, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a friendly message if an address is scanned
3 participants