Parse and construct function together #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tbaut
commented
Aug 26, 2019
maciejhirsz
reviewed
Aug 26, 2019
maciejhirsz
reviewed
Aug 26, 2019
maciejhirsz
reviewed
Aug 26, 2019
maciejhirsz
approved these changes
Aug 26, 2019
Tbaut
commented
Aug 26, 2019
|
Sorry @maciejhirsz for the extra work, I needed to refactor a bit to be able to keep relevant tests. |
pmespresso
reviewed
Aug 26, 2019
pmespresso
reviewed
Aug 26, 2019
hanwencheng
reviewed
Aug 26, 2019
| accounts.updateNew({ address, derivationPath, derivationPassword, seed: suri, seedPhrase, validBip39Seed: true }) | ||
| }) | ||
| .catch(() => { | ||
| //invalid phrase |
There was a problem hiding this comment.
This one error catch may be redundant?
There was a problem hiding this comment.
I don't think so since the catch is specific to substrateAddress whereas the other is for constructSURI
|
Tested on iOS, LGTM, only one minor comment. |
hanwencheng
approved these changes
Aug 26, 2019
Co-Authored-By: YJ <yjkimjunior@gmail.com>
Co-Authored-By: YJ <yjkimjunior@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the concerns raised in our discussions to have a parsing and constructing function together.