-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UOS Qr Support (rebased on master) #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple nits, I'll build and test tomorrow
When linking or unlinking rn-camera I get an error: react-native link react-native-camera
error Linking "react-native-camera" failed. Run CLI with --verbose flag for more details.
SyntaxError: Expected [\n\r] but end of input found.
at peg$buildStructuredError (/home/thib/github/parity-signer/node_modules/xcode/lib/parser/pbxproj.js:429:12)
at Object.peg$parse [as parse] (/home/thib/github/parity-signer/node_modules/xcode/lib/parser/pbxproj.js:1891:11)
at pbxProject.parseSync (/home/thib/github/parity-signer/node_modules/xcode/lib/pbxProject.js:63:24)
at isInstalled (/home/thib/github/parity-signer/node_modules/@react-native-community/cli-platform-ios/build/link/isInstalled.js:44:67)
at Object.isInstalled (/home/thib/github/parity-signer/node_modules/@react-native-community/cli-platform-ios/build/link/common/isInstalled.js:23:35)
at Object.keys.forEach.platform (/home/thib/github/parity-signer/node_modules/@react-native-community/cli/build/commands/link/linkDependency.js:53:36)
at Array.forEach (<anonymous>)
at linkDependency (/home/thib/github/parity-signer/node_modules/@react-native-community/cli/build/commands/link/linkDependency.js:36:32)
at process._tickCallback (internal/process/next_tick.js:68:7)
at Function.Module.runMain (internal/modules/cjs/loader.js:834:11) I can manually add the linking for android sure, but since this error is in ios files.. better let you know |
Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well on android 🎉
I made a new branch for rebasing #273 rather than force pushing. Unit tests pass and the tested the same QRs from https://uostestqrs.herokuapp.com/ as well on iOS.
UOS introduction
format, with extra information at the end (either achainId
or agenesisHash
)keccak
for Ethereum,sr25519
ored25519
for Substrate.