-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix react native warnings #309
Conversation
5d7639b
to
918d81d
Compare
I will merge this PR after these bigger ones are merged. |
constructor(){ | ||
super(); | ||
if (__DEV__) { | ||
YellowBox.ignoreWarnings([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it's a good idea to ignore them. I think it's ok to keep them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is just annoying, have to click the dismiss
button everytime, plus now we have cleaned our code and know that warnings only comes from the dependencies. Let's keep eyes on new code of componentWill*
method, I think there is little probabilities that we will use these lifecycles methods since we now have React Hooks to use.
src/components/AccountIcon.js
Outdated
@@ -17,54 +17,35 @@ | |||
'use strict'; | |||
|
|||
import PropTypes from 'prop-types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used hooks now in the substrate re-factoring for this file here: https://github.com/paritytech/parity-signer/pull/293/files#diff-4f18afcbf235db6a111ab00e2a6bee19L24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
All the major PRs have been now so that this one can go in :) |
918d81d
to
7616a0a
Compare
7616a0a
to
1621a2a
Compare
This reverts commit 1621a2a.
Needs review before merging 😞 |
close #271 , closes #277
Remove all the
componentWillReceiveProps
,componentWillMount
,componentWillUpdate
method in our code base, whereas the warning with the dependency react-native-markdown-renderer. So I use React NativeignoreWarning
method in the entry point of the app, i.e.App.js
. ine036a5d
cc53f25 , a68295b Refactored QrView and AccountIcon component with React hooks.
0df5839 DataDetail component is not used anywhere, and global
styles.js
file does not existed, so remove all of them.4fd58b7 : Remove another warning of the iOS Native code threading problem