Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keyboard aware scroll view related problem #291

Merged
merged 5 commits into from
Jul 31, 2019
Merged

Fix keyboard aware scroll view related problem #291

merged 5 commits into from
Jul 31, 2019

Conversation

hanwencheng
Copy link
Contributor

@hanwencheng hanwencheng commented Jul 29, 2019 •
edited
Loading

fix #278

  • 96c3539: fix double tap problem on Android and half covered text input on iOS related to

#268

  • 10e97b4: every click on seed input field will trigger scroll
  • 0d29f30: align seed input to top on android, so iOS and Android are same now
  • b40b6da: prettier the code and remove useless import

Screenshots here (too big cannot upload on Github):
https://drive.google.com/file/d/1g-o_XmShquI9U52agOQUl4VBX9jBujOE/view

@hanwencheng hanwencheng changed the title Hanwen scroll fix Fix keyboard aware scroll view related problem Jul 29, 2019
Tbaut
Tbaut reviewed Jul 29, 2019
View reviewed changes
Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well on Android. The double tap is gone and I can see the suggestions while typing 👍

Just found a couple nits.

src/screens/AccountRecover.js Outdated Show resolved Hide resolved
src/screens/AccountRecover.js Outdated Show resolved Hide resolved
src/components/AccountSeed.js Show resolved Hide resolved
src/screens/AccountRecover.js Outdated Show resolved Hide resolved
src/screens/AccountRecover.js Outdated Show resolved Hide resolved
src/screens/AccountRecover.js Outdated Show resolved Hide resolved
src/screens/AccountRecover.js Outdated Show resolved Hide resolved
src/screens/AccountRecover.js Outdated Show resolved Hide resolved
Tbaut
Tbaut approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can merge once YJ gives a ✔️ after an iphone test.

@hanwencheng
Copy link
Contributor Author

YJ gave the iphone to me, I will test it later today.

@hanwencheng
Copy link
Contributor Author

out

Tested on iPhone, looks good.

@hanwencheng hanwencheng merged commit fe2841a into master Jul 31, 2019
@hanwencheng hanwencheng mentioned this pull request Dec 4, 2019
Closed
@hanwencheng hanwencheng deleted the hanwen-scroll-fix branch January 3, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@maciejhirsz maciejhirsz Awaiting requested review from maciejhirsz

@pmespresso pmespresso Awaiting requested review from pmespresso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double tap needed in scrollview
2 participants
@hanwencheng @Tbaut