Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security header refresh #286

Merged
merged 4 commits into from
Jul 25, 2019
Merged

Security header refresh #286

merged 4 commits into from
Jul 25, 2019

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Jul 25, 2019

Todo

  • Triple check that the removed permission doesn't affect how things work even on an apk. Done, built an apk and it launched and worked without trouble. ✅

@hanwencheng
Copy link
Contributor

out
Meet weird problem on iOS simulator, the state does not change when user click back.
I also set the breakpoint there and the listener is not called.

Need to be checked on real iOS device, probably is because simulator's problem

@hanwencheng
Copy link
Contributor

hanwencheng commented Jul 25, 2019

ignore it since it is a known issue (edit: with the simulator)

@pmespresso
Copy link
Contributor

LGTM!

YljP3AEUYI

@Tbaut
Copy link
Contributor Author

Tbaut commented Jul 25, 2019

Real iPhone test successful by @yjkimjunior :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants