-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jest to 24.8.0 #243
Bump jest to 24.8.0 #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like there's two lock files. I think it's generally best practice to choose one or the other (yarn or npm) to avoid inconsistencies.
Do you mean I should remove the |
As long as it's consistent it should be no problem. Dug a little into past PR's where just the |
I don't have any strong feelings for or against yarn/npm, so adding whichever lock file on .gitignore and then using the other is fine with me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @Tbaut could you please also add one of the lock files to gitignore in this PR? shouldn't really matter which one :)
I went for removing the yarn.lock and adding it to .gitignore, |
ah I just realized the I will change this to |
Consider to read this:
|
Self explanatory, and more sensible this time :)
Tested successfully the build and functionnalities on android.