Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional account validation added #204

Merged
merged 1 commit into from
Jan 20, 2019
Merged

Conversation

lexfrl
Copy link
Contributor

@lexfrl lexfrl commented Jan 16, 2019

fixes #127

@ltfschoen
Copy link
Contributor

I think it would help to disable the Next Step button by default and enable it in a different colour when all the input fields are valid.

I also think we should highlight what form fields still need to be completed before the Next Step button will be enabled.

@Tbaut
Copy link
Contributor

Tbaut commented Jan 16, 2019

We will not do a release for this fix. The release will be done for the next feature that we expect to have which is Bip39 support.

@lexfrl
Copy link
Contributor Author

lexfrl commented Jan 16, 2019

I think it would help to disable the Next Step button by default and enable it in a different colour when all the input fields are valid.

I also think we should highlight what form fields still need to be completed before the Next Step button will be enabled.

It's just a quick fix for the exact annoying issue. If it doesn't makes the app any better - we can just leave it as it is and close this PR.

Copy link
Contributor

@maciejhirsz maciejhirsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@lexfrl lexfrl merged commit f641e03 into master Jan 20, 2019
@ltfschoen
Copy link
Contributor

I just tried these changes and they work great!

@debris debris deleted the account-select-validation branch January 28, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No recovery words on Backup Account screen
4 participants