-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error messages when wrong pin is entered #195
Conversation
cool! Could you attach some screenshots also? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Small grumbles though
^ the description of the issue :) I'll remove those |
It should be good to go if you want to have a look :) |
As we discussed before, we's better to not change the current |
Here we go, I've moved the error message to the state. Let me know your thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect! One small grumble.
this.setState({ pin }); | ||
if (pin.length < 1) { | ||
onChangeText={async (pin) => { | ||
this.setState({ pin: pin }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be leaved as just this.setState({ pin });
Screenshots: