Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show qr code right away #188

Merged
merged 4 commits into from
Nov 21, 2018
Merged

Show qr code right away #188

merged 4 commits into from
Nov 21, 2018

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Nov 19, 2018

Fix #163

lexfrl
lexfrl approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@lexfrl lexfrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor grumbles

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
lexfrl
lexfrl suggested changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@lexfrl lexfrl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@lexfrl
Copy link
Contributor

lexfrl commented Nov 20, 2018

please, remove the updated package-lock.json from the PR as well

@lexfrl lexfrl merged commit d8c21f5 into master Nov 21, 2018
@Tbaut Tbaut deleted the tbaut-show-qr-code branch November 27, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexfrl lexfrl lexfrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tbaut @lexfrl