Removed google-service-json and setup CI #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changed google-service files to base64 format, as it suffer from formatting issue. Tested by: |
.github/workflows/android_build.yml
Outdated
Comment on lines
126
to
140
| - name: 📂 Set up DEV Google Services | ||
| if: ${{ !startsWith(inputs.gradlew-command, 'false') }} | ||
| uses: davidSchuppa/base64Secret-toFile-action@v3 | ||
| with: | ||
| secret: ${{ env.CI_DEVELOP_GOOGLE_SERVICES_FILE }} | ||
| filename: google-services.json | ||
| destination-path: ./app | ||
|
|
||
| - name: 📂 Set up PROD Google Services | ||
| if: ${{ !startsWith(inputs.gradlew-command, 'false') }} | ||
| uses: davidSchuppa/base64Secret-toFile-action@v3 | ||
| with: | ||
| secret: ${{ env.CI_PRODUCTION_GOOGLE_SERVICES_FILE }} | ||
| filename: google-services.json | ||
| destination-path: ./app/src/release/ |
There was a problem hiding this comment.
@valentunn The dev google-services I put to common folder (app/) and for release build it should be overridden by app/src/release/
valentunn
approved these changes
Feb 27, 2024
stepanLav
approved these changes
Feb 27, 2024
|
The workflow is fallen because the develop branch doesn't contain changes yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.