Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Multisig single chain view #2649

Merged
merged 9 commits into from
Nov 15, 2024
Merged

Fix: Multisig single chain view #2649

merged 9 commits into from
Nov 15, 2024

Conversation

tuul-wq
Copy link
Contributor

@tuul-wq tuul-wq commented Nov 14, 2024 •
edited
Loading

  • Updated Multisig wallet details for a single chain
  • Better TS support for dictionary utility function
  • Correct determination of signatories (wallets, contacts, others)

closes #2550

image

@tuul-wq tuul-wq self-assigned this Nov 14, 2024
@tuul-wq
Merge branch 'dev' into fix/msig_single
cb75770 
# Conflicts:
#	src/renderer/entities/wallet/ui/Cards/WalletCardMd.tsx
#	src/renderer/widgets/WalletDetails/model/__tests__/wallet-provider-model.test.ts
@tuul-wq
fix: wrong address
fab875e
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

Jest Unit tests results

Generic badge

Duration: 58.652 seconds
Start: 2024-11-15 13:47:17.611 UTC
Finish: 2024-11-15 13:48:16.263 UTC
Duration: 58.652 seconds
Outcome: Passed | Total Tests: 744 | Passed: 743 | Failed: 0
Total Test Suites: 159
Total Tests: 744
Failed Test Suites: 0
Failed Tests: 0
Passed Test Suites: 158
Passed Tests: 743
Pending Test Suites: 1
Pending Tests: 1

@tuul-wq tuul-wq changed the base branch from dev to feat/flexible-multisig November 14, 2024 12:47
@tuul-wq tuul-wq requested a review from johnthecat November 14, 2024 13:56
@tuul-wq tuul-wq merged commit 2c3f5f7 into feat/flexible-multisig Nov 15, 2024
3 checks passed
@tuul-wq tuul-wq deleted the fix/msig_single branch November 15, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Asmadek Asmadek Awaiting requested review from Asmadek

@sokolova-an sokolova-an Awaiting requested review from sokolova-an

@johnthecat johnthecat Awaiting requested review from johnthecat

Assignees

@tuul-wq tuul-wq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flexible multisig. Rework wallet details for multisig
2 participants
@tuul-wq @johnthecat