Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Multisig select #2626

Merged
merged 16 commits into from
Nov 15, 2024
Merged

Fix: Multisig select #2626

merged 16 commits into from
Nov 15, 2024

Conversation

tuul-wq
Copy link
Contributor

@tuul-wq tuul-wq commented Nov 12, 2024 •
edited
Loading

  • Use new <Select /> to make dropdown part come out from the modal window
  • Form field contains ChainId instead of Chain so I had to make adjustments
  • Contains <Field /> component

closes #2584

image

@tuul-wq tuul-wq self-assigned this Nov 12, 2024
@tuul-wq tuul-wq changed the base branch from dev to fix/ui_kit_label November 12, 2024 09:18
@tuul-wq tuul-wq changed the title Fix/msig select Fix: Multisig select Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Jest Unit tests results

Generic badge

Duration: 61.51 seconds
Start: 2024-11-15 13:34:09.779 UTC
Finish: 2024-11-15 13:35:11.289 UTC
Duration: 61.51 seconds
Outcome: Passed | Total Tests: 738 | Passed: 737 | Failed: 0
Total Test Suites: 159
Total Tests: 738
Failed Test Suites: 0
Failed Tests: 0
Passed Test Suites: 158
Passed Tests: 737
Pending Test Suites: 1
Pending Tests: 1

@tuul-wq tuul-wq changed the base branch from fix/ui_kit_label to feat/ui_kit_select November 12, 2024 09:19
Base automatically changed from feat/ui_kit_select to dev November 14, 2024 10:54
johnthecat
johnthecat reviewed Nov 14, 2024
View reviewed changes
src/renderer/shared/ui-kit/Field/Field.stories.tsx Outdated Show resolved Hide resolved
src/renderer/shared/ui-kit/Select/Select.tsx Outdated Show resolved Hide resolved
src/renderer/shared/ui-kit/Select/Select.stories.tsx Outdated Show resolved Hide resolved
src/renderer/shared/ui-kit/Select/Select.tsx Show resolved Hide resolved
src/renderer/widgets/CreateWallet/model/confirm-model.ts Outdated Show resolved Hide resolved
src/renderer/widgets/CreateWallet/model/form-model.ts Outdated Show resolved Hide resolved
src/renderer/widgets/CreateWallet/model/form-model.ts Outdated Show resolved Hide resolved
src/renderer/widgets/CreateWallet/ui/MultisigWallet/ConfirmationStep.tsx Outdated Show resolved Hide resolved
src/renderer/widgets/CreateWallet/ui/MultisigWallet/NameNetworkSelection.tsx Outdated Show resolved Hide resolved
src/renderer/widgets/CreateWallet/ui/MultisigWallet/components/Signatory.tsx Outdated Show resolved Hide resolved
@tuul-wq tuul-wq changed the base branch from dev to feat/flexible-multisig November 15, 2024 11:11
@tuul-wq
fix: strict asset
e405963
@tuul-wq
Merge branch 'feat/flexible-multisig' into fix/msig_select
3d202f9 
# Conflicts:
#	src/renderer/widgets/CreateWallet/model/flow-model.ts
#	src/renderer/widgets/CreateWallet/ui/MultisigWallet/components/Signatory.tsx
@tuul-wq
fix: select merge error
a5edb4d
@tuul-wq tuul-wq merged commit 6749c67 into feat/flexible-multisig Nov 15, 2024
3 checks passed
@tuul-wq tuul-wq deleted the fix/msig_select branch November 15, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnthecat johnthecat johnthecat approved these changes

@Asmadek Asmadek Awaiting requested review from Asmadek

@sokolova-an sokolova-an Awaiting requested review from sokolova-an

Assignees

@tuul-wq tuul-wq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multisig. Multisig creation. Network list opens inside the window
2 participants
@tuul-wq @johnthecat