Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Combobox #2574

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Feat: Combobox #2574

merged 7 commits into from
Nov 14, 2024

Conversation

tuul-wq
Copy link
Contributor

@tuul-wq tuul-wq commented Nov 5, 2024

  • New Combobox
  • Use @ariakit/react to make Radix-UI Popover work with Input as trigger
  • Updated onChange for <Input /> to make it compatible with @ariakit/react and versatile overall

related to #2490

image

@tuul-wq tuul-wq self-assigned this Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Jest Unit tests results

Generic badge

Duration: 58.719 seconds
Start: 2024-11-14 11:27:33.351 UTC
Finish: 2024-11-14 11:28:32.070 UTC
Duration: 58.719 seconds
Outcome: Passed | Total Tests: 738 | Passed: 737 | Failed: 0
Total Test Suites: 159
Total Tests: 738
Failed Test Suites: 0
Failed Tests: 0
Passed Test Suites: 158
Passed Tests: 737
Pending Test Suites: 1
Pending Tests: 1

package.json Outdated Show resolved Hide resolved
src/renderer/shared/ui-kit/Combobox/Combobox.tsx Outdated Show resolved Hide resolved
src/renderer/shared/ui-kit/Combobox/Combobox.tsx Outdated Show resolved Hide resolved
src/renderer/shared/ui-kit/Combobox/Combobox.tsx Outdated Show resolved Hide resolved
src/renderer/shared/ui-kit/Combobox/Combobox.tsx Outdated Show resolved Hide resolved
src/renderer/shared/ui-kit/Combobox/Combobox.tsx Outdated Show resolved Hide resolved
src/renderer/shared/ui-kit/Combobox/Combobox.tsx Outdated Show resolved Hide resolved
@tuul-wq tuul-wq changed the base branch from dev to feat/flexible-multisig November 7, 2024 07:02
@tuul-wq tuul-wq requested a review from johnthecat November 8, 2024 08:49
@tuul-wq tuul-wq changed the base branch from feat/flexible-multisig to feat/input November 8, 2024 08:49
# Conflicts:
#	src/renderer/widgets/CreateWallet/ui/MultisigWallet/components/Signatory.tsx
@tuul-wq tuul-wq merged commit d6bb315 into feat/input Nov 14, 2024
3 checks passed
@tuul-wq tuul-wq deleted the feat/combobox branch November 14, 2024 12:14
@tuul-wq tuul-wq restored the feat/combobox branch November 19, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants