refactor: rearrange of wallet select feature, removed some modules connection #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest Unit tests resultsDuration: 58.06 seconds
Outcome: Passed | Total Tests: 735 | Passed: 734 | Failed: 0
|
sokolova-an
approved these changes
Nov 5, 2024
Asmadek
approved these changes
Nov 5, 2024
src/renderer/features/wallet-fiat-balance/components/WalletFiatBalance.tsx
Outdated
Show resolved
Hide resolved
tuul-wq
reviewed
Nov 6, 2024
src/renderer/features/wallet-fiat-balance/service/__tests__/walletSelectService.test.ts
Show resolved
Hide resolved
src/renderer/features/wallet-select/service/__tests__/walletSelectService.test.ts
Show resolved
Hide resolved
johnthecat
force-pushed
the
refactor/wallet-select
branch
from
0549c28 to
1b17af9
Compare
tuul-wq
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #2542
Main goal was to prepare wallet selection feature to accept di and make it more readable