Feat: Multisig creation with remark

package.json

@@ -204,7 +204,7 @@
     "nodemon": "^2.0.18",
     "npm-run-all": "^4.1.5",
     "playwright": "^1.44.1",
-    "pnpm": "^9.2.0",
+    "pnpm": "^9.4.0",
     "postcss": "^8.4.31",
     "postcss-loader": "^7.3.3",
     "prettier": "3.3.3",

src/renderer/entities/contact/model/contact-model.ts

@@ -14,6 +14,10 @@ const createContactFx = createEffect(async (contact: Omit<Contact, 'id'>): Promi
   return storageService.contacts.create(contact);
 });
 
+const createContactsFx = createEffect((contacts: Omit<Contact, 'id'>[]): Promise<Contact | undefined>[] => {
+  return contacts.map(async (contact) => storageService.contacts.create(contact));
+});
+
 const updateContactFx = createEffect(async ({ id, ...rest }: Contact): Promise<Contact> => {
   await storageService.contacts.update(id, rest);
 
@@ -51,6 +55,7 @@ export const contactModel = {
   $contacts,
   effects: {
     createContactFx,
+    createContactsFx,
     deleteContactFx,
     updateContactFx,
   },

src/renderer/entities/contact/ui/ContactList.tsx

@@ -8,7 +8,7 @@ export const ContactList = ({ children }: PropsWithChildren) => {
 
   return (
     <div className="flex flex-col gap-y-2">
-      <div className="grid grid-cols-[250px,250px,1fr] items-center px-3">
+      <div className="grid grid-cols-[250px,1fr] items-center px-3">
         <FootnoteText className="text-text-secondary">{t('addressBook.contactList.nameColumnTitle')}</FootnoteText>
       </div>
 

src/renderer/entities/transaction/lib/callDataDecoder.ts

@@ -165,12 +165,12 @@
 
   const getCallDataParser: Record<
     TransactionType,
     (decoded: SubmittableExtrinsic<'promise'>, chainId: ChainId) => Record<string, any>
   > = {
     [TransactionType.TRANSFER]: (decoded): Record<string, any> => {
       return { dest: decoded.args[0].toString(), value: decoded.args[1].toString() };
     },
     [TransactionType.ASSET_TRANSFER]: (decoded): Record<string, any> => {
       return {
         assetId: decoded.args[0].toString(),
         dest: decoded.args[1].toString(),
@@ -362,6 +362,9 @@
         call: decoded.args[2].toHex(),
       };
     },
+    [TransactionType.REMARK]: (decoded): Record<string, any> => {
+      return { remark: decoded.args[0].toString() };
+    },
     [TransactionType.UNLOCK]: (decoded): Record<string, any> => {
       return {
         class: decoded.args[0].toString(),

src/renderer/entities/transaction/lib/common/utils.ts

@@ -229,6 +229,8 @@ const TransactionTitles: Record<TransactionType, string> = {
   [TransactionType.REMOVE_PROXY]: 'operations.titles.removeProxy',
   [TransactionType.REMOVE_PURE_PROXY]: 'operations.titles.removePureProxy',
   [TransactionType.PROXY]: 'operations.titles.proxy',
+  // Remark
+  [TransactionType.REMARK]: 'operations.titles.remark',
   // Governance
   [TransactionType.UNLOCK]: 'operations.titles.unlock',
   [TransactionType.VOTE]: 'operations.titles.vote',
@@ -277,6 +279,9 @@ const TransactionTitlesModal: Record<TransactionType, (crossChain: boolean) => s
   [TransactionType.REMOVE_PROXY]: () => 'operations.modalTitles.removeProxy',
   [TransactionType.REMOVE_PURE_PROXY]: () => 'operations.modalTitles.removePureProxy',
   [TransactionType.PROXY]: () => 'operations.modalTitles.proxy',
+  // Remark
+  [TransactionType.REMARK]: () => 'operations.modalTitles.remark',
+  // Governance
   [TransactionType.UNLOCK]: () => 'operations.modalTitles.unlockOn',
   [TransactionType.VOTE]: () => 'operations.modalTitles.vote',
   [TransactionType.REVOTE]: () => 'operations.modalTitles.revote',

src/renderer/entities/transaction/lib/extrinsicService.ts

@@ -370,6 +370,17 @@ export const getUnsignedTransaction: Record<
       options,
     );
   },
+
+  [TransactionType.REMARK]: (transaction, info, options) => {
+    return methods.system.remark(
+      {
+        remark: transaction.args.remark,
+      },
+      info,
+      options,
+    );
+  },
+
   [TransactionType.UNLOCK]: (transaction, info, options) => {
     return convictionVotingMethods.unlock(
       {
@@ -532,6 +543,7 @@ export const getExtrinsic: Record<
   [TransactionType.CREATE_PURE_PROXY]: ({ proxyType, delay, index }, api) => {
     return api.tx.proxy.createPure(proxyType, delay, index);
   },
+  [TransactionType.REMARK]: ({ remark }, api) => api.tx.system.remark(remark),
   [TransactionType.UNLOCK]: ({ target, trackId }, api) => {
     return api.tx.convictionVoting.unlock(trackId, target);
   },

src/renderer/entities/transaction/lib/transactionConfirmIcon.ts

@@ -34,6 +34,8 @@ const TransactionIcons: Record<TransactionType, IconNames> = {
   [TransactionType.REMOVE_PROXY]: 'proxyConfirm',
   [TransactionType.REMOVE_PURE_PROXY]: 'proxyConfirm',
   [TransactionType.PROXY]: 'unknownConfirm',
+  // Remark
+  [TransactionType.REMARK]: 'unknownConfirm',
   // Governance
   [TransactionType.UNLOCK]: 'unlockMst',
   [TransactionType.VOTE]: 'voteMst',

src/renderer/entities/transaction/lib/transactionIcon.ts

@@ -34,6 +34,8 @@ const TransactionIcons: Record<TransactionType, IconNames> = {
   [TransactionType.REMOVE_PROXY]: 'proxyMst',
   [TransactionType.REMOVE_PURE_PROXY]: 'proxyMst',
   [TransactionType.PROXY]: 'unknownMst',
+  // Remark
+  [TransactionType.REMARK]: 'unknownMst',
   // Governance
   [TransactionType.UNLOCK]: 'unlockMst',
   [TransactionType.VOTE]: 'voteMst',

src/renderer/entities/wallet/lib/wallet-utils.ts

@@ -81,6 +81,7 @@ function isWalletConnectGroup(wallet?: Wallet): wallet is WalletConnectGroup {
 }
 
 const VALID_SIGNATORY_WALLET_TYPES = [
+  WalletType.POLKADOT_VAULT,
   WalletType.SINGLE_PARITY_SIGNER,
   WalletType.MULTISHARD_PARITY_SIGNER,
   WalletType.WALLET_CONNECT,

src/renderer/features/notifications/NotificationsList/ui/notifies/MultisigCreatedNotification.tsx

@@ -4,14 +4,15 @@ import { useI18n } from '@app/providers';
 import { type MultisigCreated } from '@shared/core';
 import { WalletType } from '@shared/core';
 import { BodyText } from '@shared/ui';
+import { ChainTitle } from '@entities/chain';
 import { WalletIcon } from '@entities/wallet';
 
 type Props = {
   notification: MultisigCreated;
 };
 
 export const MultisigCreatedNotification = ({
-  notification: { threshold, signatories, multisigAccountName },
+  notification: { threshold, signatories, multisigAccountName, chainId },
 }: Props) => {
   const { t } = useI18n();
 
@@ -33,6 +34,9 @@ export const MultisigCreatedNotification = ({
               signatoriesLength: signatories.length,
               name: multisigAccountName,
             }}
+            components={{
+              chain: <ChainTitle chainId={chainId} fontClass="text-text-primary text-body" />,
+            }}
           />
         </BodyText>
       </div>

src/renderer/pages/Basket/lib/operation-title.ts

@@ -63,6 +63,8 @@ export const getOperationTitle = (transaction: BasketTransaction, chain: Chain):
     [TransactionType.VOTE]: 'operations.modalTitles.vote',
     [TransactionType.REVOTE]: 'operations.modalTitles.revote',
     [TransactionType.REMOVE_VOTE]: 'operations.modalTitles.removeVote',
+    // Remark
+    [TransactionType.REMARK]: 'operations.modalTitles.remarkOn',
   };
 
   // @ts-expect-error TODO fix not all types used

src/renderer/pages/Basket/model/basket-page-model.ts

@@ -136,8 +136,10 @@ const validateFx = createEffect(({ transactions, feeMap }: ValidateParams) => {
         | XcmTransactionTypes
         | MultisigTransactionTypes
         | UtilityTransactionTypes
+
         // TODO: Add remove vote types
         | TransactionType.REMOVE_VOTE
+        | TransactionType.REMARK
       >,
       EventCallable<ValidationStartedParams>
     > = {

src/renderer/pages/Basket/model/sign-operations-model.ts

@@ -107,6 +107,7 @@ const startDataPreparationFx = createEffect(async ({ transactions, ...preparatio
         | TransactionType.VOTE
         | TransactionType.REMOVE_VOTE
         | TransactionType.REVOTE
+        | TransactionType.REMARK
       >,
       (dataParams: DataParams) => Promise<unknown>
     > = {

src/renderer/pages/Basket/ui/SignOperation.tsx

@@ -90,7 +90,11 @@ export const SignOperation = () => {
     const Components: Record<
       Exclude<
         TransactionType,
-        TransferTransactionTypes | XcmTransactionTypes | MultisigTransactionTypes | UtilityTransactionTypes
+        | TransferTransactionTypes
+        | XcmTransactionTypes
+        | MultisigTransactionTypes
+        | UtilityTransactionTypes
+        | TransactionType.REMARK
       >,
       () => ReactNode
     > = {

src/renderer/pages/Basket/ui/SignOperations.tsx

@@ -91,7 +91,11 @@ export const SignOperations = () => {
     const Components: Record<
       Exclude<
         TransactionType,
-        TransferTransactionTypes | XcmTransactionTypes | MultisigTransactionTypes | UtilityTransactionTypes
+        | TransferTransactionTypes
+        | XcmTransactionTypes
+        | MultisigTransactionTypes
+        | UtilityTransactionTypes
+        | TransactionType.REMARK
       >,
       () => ReactNode
     > = {

src/renderer/pages/Operations/components/ActionSteps/Submit.tsx

@@ -27,7 +27,6 @@ type Props = {
   txPayload: Uint8Array;
   signature: HexString;
   rejectReason?: string;
-
   isReject?: boolean;
   onClose: () => void;
 };

src/renderer/processes/multisigs/model/__tests__/multisigs-model.test.ts

@@ -6,6 +6,7 @@ import {
   ChainType,
   ConnectionType,
   CryptoType,
+  ExternalType,
   SigningType,
   WalletType,
 } from '@shared/core';
@@ -76,7 +77,7 @@ describe('features/multisigs/model/multisigs-model', () => {
             chainId: '0x01',
             name: 'Westend',
             options: [ChainOptions.MULTISIG],
-            externalApi: { multisig: [{ url: 'http://mock-url' }] },
+            externalApi: { [ExternalType.PROXY]: [{ url: 'http://mock-url' }] },
           },
         }),
     });

src/renderer/processes/multisigs/model/multisigs-model.ts

@@ -30,7 +30,8 @@ const multisigSaved = createEvent<GetMultisigsResult>();
 const $multisigChains = combine(networkModel.$chains, (chains) => {
   return Object.values(chains).filter((chain) => {
     const isMultisigSupported = multisigUtils.isMultisigSupported(chain);
-    const hasIndexerUrl = chain.externalApi?.[ExternalType.MULTISIG]?.[0]?.url;
+    const hasIndexerUrl =
+      networkUtils.isMultisigSupported(chain.options) && chain.externalApi?.[ExternalType.PROXY]?.[0]?.url;
 
     return isMultisigSupported && hasIndexerUrl;
   });
@@ -48,8 +49,13 @@ type GetMultisigsResult = {
 
 const getMultisigsFx = createEffect(({ chains, wallets }: GetMultisigsParams) => {
   for (const chain of chains) {
-    const accounts = walletUtils.getAccountsBy(wallets, (a) => accountUtils.isChainIdMatch(a, chain.chainId));
-    const multisigIndexerUrl = chain.externalApi?.[ExternalType.MULTISIG]?.[0]?.url;
+    const filteredWallets = walletUtils.getWalletsFilteredAccounts(wallets, {
+      walletFn: (w) => !walletUtils.isMultisig(w) && !walletUtils.isWatchOnly(w) && !walletUtils.isProxied(w),
+    });
+    const accounts = walletUtils.getAccountsBy(filteredWallets || [], (a) =>
+      accountUtils.isChainIdMatch(a, chain.chainId),
+    );
+    const multisigIndexerUrl = chain.externalApi?.[ExternalType.PROXY]?.[0]?.url;
     const boundMultisigSaved = scopeBind(multisigSaved, { safe: true });
 
     if (!multisigIndexerUrl || !accounts.length) continue;