Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox url generation moved from JS to PHP #67

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

phplego
Copy link
Contributor

@phplego phplego commented Jun 27, 2015

Related to issue:
"Suffix in the urlManager makes Admin Panel broken #65"

@noumo
Copy link
Owner

noumo commented Jun 27, 2015

There is a problem in this patch...
Almost all switchers proccessed via ajax request. With your changes data-link will be in 1 state on or off (without page reload).

@phplego
Copy link
Contributor Author

phplego commented Jun 28, 2015

Now it should work properly.
But, anyway I think all ajax queries should go though one action (for example actionAjax) or through one controller (for example AjaxController) and via POST method.

And In my view it would be nice if we split application entry point to two files: index.php and admin.php with different config inclusions.

@noumo
Copy link
Owner

noumo commented Jun 30, 2015

So this changes fixes something?

And In my view it would be nice if we split application entry point to two files: index.php and admin.php with different config inclusions

No, easyii is only a module and about frontend or application knows nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants