Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update #31

Merged
merged 65 commits into from
May 20, 2023
Merged

update #31

merged 65 commits into from
May 20, 2023

Conversation

MasterPi-2124
Copy link

Closes: #XXX

What is the purpose of the change

Add a description of the overall background and high level changes that this PR introduces

(E.g.: This pull request improves documation of area A by adding ....

Brief Changelog

(for example:)

  • The metadata is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • Daemons retrieve the RPC data from the blob cache

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added unit test that validates ...
  • Added integration tests for end-to-end deployment with ...
  • Extended integration test for ...
  • Manually verified the change by ...

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

dependabot bot and others added 30 commits May 11, 2023 16:23
@dependabot
chore(deps): bump lycheeverse/lychee-action from 1.6.1 to 1.7.0 (#5158)
457b82b 
Bumps [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/lycheeverse/lychee-action/releases)
- [Commits](lycheeverse/lychee-action@v1.6.1...v1.7.0)

---
updated-dependencies:
- dependency-name: lycheeverse/lychee-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump actions/cache from 2 to 3 (#5145)
2829138 
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v2...v3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump mheap/github-action-required-labels from 2 to 4 (#5146
49ca361 
)

Bumps [mheap/github-action-required-labels](https://github.com/mheap/github-action-required-labels) from 2 to 4.
- [Release notes](https://github.com/mheap/github-action-required-labels/releases)
- [Commits](mheap/github-action-required-labels@v2...v4)

---
updated-dependencies:
- dependency-name: mheap/github-action-required-labels
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ValarDragon
Clarify error message when you try to completely exit a pool (#5165)
c087264 
* Clarify error message when you try to completely exit a pool

Closes #3427

* Add changelog
@ValarDragon @p0mvn @czarcas7ic
Remove a section of PR template (#5166)
44e8c7b 
* Remove a section of PR template

* Update .github/pull_request_template.md

Co-authored-by: Adam Tucker <adam@osmosis.team>

---------

Co-authored-by: Roman <roman@osmosis.team>
Co-authored-by: Adam Tucker <adam@osmosis.team>
@AlpinYukseloglu @stackman27
[CL Message Audit] MsgSwapExactAmountIn (#5123)
52fcea8 
* add comments from audit

* add tests for untested files and fix minor bugs and issues

* add test for rounding behavior

* clean up comments

* fix conflicts

* fix conflicts in tests relating to rounding changes

* romans and adams feedback

---------

Co-authored-by: stackman27 <sis1001@berkeley.edu>
@ValarDragon
Speedup accumulator prefix keys (#5174)
01e4469
@ValarDragon
Speedup some of the swap logic by doing more pre-computation in tick …
f60b062 
…math (#5171)
@pysel
osmomath: disable thelper for some helper functions (#5164)
13c81d8 
* mark helper functions

* disable thelper warnings
@dependabot
chore(deps): bump lycheeverse/lychee-action from 1.7.0 to 1.8.0 (#5180)
c673324 
Bumps [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/lycheeverse/lychee-action/releases)
- [Commits](lycheeverse/lychee-action@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: lycheeverse/lychee-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@stackman27
fix localosmosis (#5183)
1c031dd
@czarcas7ic
[CL Message Audit]: MsgUnlockAndMigrateSharesToFullRangeConcentratedP…
c9a54ac 
…osition [1/2] (#5178)

* initial push audit changes

* add back proto tag

* rename to validateGammLockForSuperfluidStaking

* remove unused errors
@czarcas7ic @mattverse
fix: duplicate price for multiple ticks (#5173)
f116d43 
* initial push

* update readme

* initial push

* implement round tick

* add test for round tick

* add readme

* return new lower and upper tick when create pos

* initial push audit changes

* use enum for migration type

* add back proto tag

* rename to validateGammLockForSuperfluidStaking

* remove unused errors

* Update x/superfluid/keeper/migrate.go

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

* add check for both bonded and unbonding

* named return values createPosition

* Update x/concentrated-liquidity/tick.go

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

* change roundTick to roundTickToCanonicalPriceTick

* initialize int64 vars

* Revert "Merge branch 'adam/MsgUnlockAndMigrateSharesToFullRangeConcentratedPosition-audit' into adam/duplicate-price-for-multiple-ticks-patch"

This reverts commit 3ace477, reversing
changes made to b5923f0.

---------

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
@p0mvn
fix: add split route message to codec and interface registration (#5168)
8485634 
* fix: add split route message to codec and interface registration

* Apply suggestions from code review

* Apply suggestions from code review
@p0mvn
refactor: remove cache context from swap out given in (#5176)
b38277c 
* refactor: remove cache from swap out given in

* updates

* dead code

* update test name

* updates
@p0mvn
[CL][InternalReview] MsgAddToConcentratedLiquiditySuperfluidPosition (#…
ad87e9e 
…5157)

* [InternalReview] MsgAddToConcentratedLiquiditySuperfluidPosition

* updates

* updates

* updates

* updates

* revert me

* updates

* debug

* docs

* go sum

* go mod

* remove

* Update x/superfluid/README.md

* Update x/concentrated-liquidity/position.go

* comment

* coins

* remove Q

* remove Q

* revert name
@p0mvn
CL: benchmark for swaps (#5170)
3f78962 
* test

* fix

* comments

* fix conflict

* updates

* normalize

* maxAmountDepositedFullRange
@dependabot
chore(deps): bump lycheeverse/lychee-action from 1.7.0 to 1.8.0 (#5188)
6e8fbee 
Bumps [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/lycheeverse/lychee-action/releases)
- [Commits](lycheeverse/lychee-action@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: lycheeverse/lychee-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@czarcas7ic
Revert "fix: duplicate price for multiple ticks (#5173)" (#5193)
78c0266 
* Revert "fix: duplicate price for multiple ticks (#5173)"

This reverts commit f116d43.

* fix merge conflicts

* regen proto
@czarcas7ic
fix: duplicate price for multiple ticks (#5196)
30fe496 
* initial push

* update gomod

* revert nolint

* update gomod
@p0mvn @ValarDragon
perf: convert ticks to int64 (#5189)
db7ced1 
* perf: convert ticks to int64

* updates

* fix test

* updates

* updates

* Update x/concentrated-liquidity/math/tick.go

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>

* nit

* comment

* comment

* >=

* lint

* lint

---------

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
@czarcas7ic @p0mvn
refactor: remove cache context from swap in given out (#5198)
64a9382 
* remove cache context from in given out

* Update x/concentrated-liquidity/swaps_test.go

Co-authored-by: Roman <roman@osmosis.team>

* Update x/concentrated-liquidity/swaps_test.go

Co-authored-by: Roman <roman@osmosis.team>

---------

Co-authored-by: Roman <roman@osmosis.team>
@p0mvn
refactor: more discriptive error when no liquidity in swaps (#5197)
4a8c846
@p0mvn
fix: merge conflict (#5199)
8e64ed4
@p0mvn
fix: make proto-docs; unsupported address proto tag (#5195)
db52beb
@mattverse @p0mvn @czarcas7ic
[CL Message Audit]: MsgWithdrawPosition (#5135)
d7bb061 
* WIP

* Add test cases

* Uncomment tests

* Uncomment more tests

* Add lock test

* And uncomment test

* Update x/concentrated-liquidity/incentives.go

Co-authored-by: Roman <roman@osmosis.team>

* Romans feedback

* Update x/concentrated-liquidity/lp.go

Co-authored-by: Adam Tucker <adam@osmosis.team>

* Update x/concentrated-liquidity/lp_test.go

Co-authored-by: Adam Tucker <adam@osmosis.team>

* Adams review

---------

Co-authored-by: Roman <roman@osmosis.team>
Co-authored-by: Adam Tucker <adam@osmosis.team>
@mattverse
Fix CL client to be compatible with recent state of Bigbang (#5200)
1d93d82 
* Fix cl client to follow most recent state

* Run go mod tidy
@mattverse
Change to A:no-changelog (#5201)
9cdd814
@p0mvn
fix: merge conflict (#5210)
747bea3
@czarcas7ic
readme error fixes (#5208)
1a6f96e
dependabot bot and others added 12 commits May 19, 2023 17:18
@dependabot
chore(deps): bump github.com/docker/docker (#5219)
b8762ff 
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.19+incompatible to 20.10.24+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v20.10.19...v20.10.24)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@czarcas7ic
feat: v16 upgrade handler updates (#5213)
3834970 
* initial push upgrade handler changes

* properly set staking denom to usomo in test

* add further tests

* use comm pool for swap

* correct pool ID

* update pool id
@mattverse @AlpinYukseloglu
@czarcas7ic @p0mvn
[CL Message Audit]: AddToPositions (#5167)
ba1660f 
* WIP

* Trying to fix test

* Fix test

* Add min amount

* Update proto/osmosis/concentrated-liquidity/tx.proto

Co-authored-by: alpo <62043214+AlpinYukseloglu@users.noreply.github.com>

* Update proto/osmosis/concentrated-liquidity/tx.proto

Co-authored-by: Adam Tucker <adam@osmosis.team>

* Update proto/osmosis/concentrated-liquidity/tx.proto

Co-authored-by: alpo <62043214+AlpinYukseloglu@users.noreply.github.com>

* Update proto/osmosis/concentrated-liquidity/tx.proto

Co-authored-by: alpo <62043214+AlpinYukseloglu@users.noreply.github.com>

* Update proto/osmosis/concentrated-liquidity/tx.proto

Co-authored-by: Adam Tucker <adam@osmosis.team>

* WIP for comments

* Review comments

* updates

---------

Co-authored-by: alpo <62043214+AlpinYukseloglu@users.noreply.github.com>
Co-authored-by: Adam Tucker <adam@osmosis.team>
Co-authored-by: Roman <roman@osmosis.team>
@czarcas7ic
perf: change KVStore value from posID to boolean byte (#5237)
806f32c 
* change KVStore value from posID to boolean byte

* replace redundant function

* fix prefix

* update godoc
@AlpinYukseloglu
add incentive creation & querying section to readme (#5242)
13cdc51
@AlpinYukseloglu
add readme section on reward splitting (#5244)
2f00ec2
@p0mvn
refactor: rename swap fee to spread factor (#5138)
9f9e1ca 
* refactor: rename swap fee to spread factor

* lint

* updates

* updates
@AlpinYukseloglu
[CL][bugfix] Update reward splitting logic to only use bonded balance…
e327f93 
…r amounts (#5239)

* implement/test necessary helper and implement/test bugfix for bonded share reward splitting

* changelog for gamm changes

* clean up tests and comments
@czarcas7ic @mattverse @p0mvn
[CL Message Audit]: MsgUnlockAndMigrateSharesToFullRangeConcentratedP…
ded75f1 
…osition [2/2] (#5160)

* initial push

* update readme

* initial push audit changes

* use enum for migration type

* add back proto tag

* rename to validateGammLockForSuperfluidStaking

* remove unused errors

* Update x/superfluid/keeper/migrate.go

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

* add check for both bonded and unbonding

* update gomod

* allow max length 1 for linked synth locks

* feat: partial superfluid undelegate (#5162)

* partial superfluid undelegate

* further reduction of gas

* Update x/superfluid/keeper/migrate.go

Co-authored-by: Roman <roman@osmosis.team>

* reduce code duplication lock and lockNoSend

* lockNoSend as default

* add bug fix with expanded tests

* unit test for CreateLockNoSend

* Update x/superfluid/keeper/migrate.go

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

* fix merge

* partialSuperfluidUndelegate named return values

* expand test checks for migrateDelegated

* expanded bonded checks

* check new lock and exact amount

* assign vars directly

* update merge

* check newly created lock

* add extra logic branch for fail case

* split up partial superfluid undelegate func

* expand partial undelegate test case

* roman's review

* Update x/lockup/keeper/lock_test.go

* nit

* fix test

* expand CreateLockNoSend comment

* rename lockNoSend back to lock

* expand partial unlock comment

---------

Co-authored-by: Roman <roman@osmosis.team>
Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

* remove unused error

* lint

---------

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
Co-authored-by: Roman <roman@osmosis.team>
@mattverse
Add amino proto annotations (#4629)
53b56a7 
* Add proto annotations

* Update go.mod

* Add changelog

* Adams review

* Make proto

---------

Co-authored-by: mattverse <mattverse@users.noreply.github.com>
@p0mvn @czarcas7ic
refactor: reinvest dust fees into pool accumulator (#5245)
50f5d6b 
* refactor: reinvest dust fees into pool accumulator

* updates

* updates

* Update x/concentrated-liquidity/fees_test.go

Co-authored-by: Adam Tucker <adam@osmosis.team>

---------

Co-authored-by: Adam Tucker <adam@osmosis.team>
@p0mvn
perf: iterator improvements for swap in given out and liquidity for f…
9bcfdd6 
…ull range query (#5248)

* perf: iterator improvements for swap in given out and liquidity for full range query

* updates
@MasterPi-2124 MasterPi-2124 merged commit 7fff202 into notional-labs:main May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:app-wiring C:CLI C:docs C:simulator C:x/concentrated-liquidity C:x/epochs C:x/gamm C:x/incentives C:x/lockup C:x/mint C:x/pool-incentives C:x/poolmanager C:x/superfluid C:x/tokenfactory C:x/txfees T:build T:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@MasterPi-2124 @ValarDragon @AlpinYukseloglu @pysel @stackman27 @czarcas7ic @p0mvn @mattverse @faddat