Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for make proto-all #79

Merged
merged 1 commit into from
Jul 30, 2022
Merged

fix for make proto-all #79

merged 1 commit into from
Jul 30, 2022

Conversation

crodriguezvega
Copy link
Collaborator

@crodriguezvega crodriguezvega commented Jul 30, 2022

Description

I think this fixes make proto-all. The culprits were:

  • the buf.lock file
  • the deps section in buf.yaml
  • the missing scalar field option in cosmos.proto

Besides that I removed confio/proofs.proto (see #583) and updated auth.proto with latest from here.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@faddat
Copy link

faddat commented Jul 30, 2022

Thanks, I am merging this, and fixing update-deps, which I think moves the confio proofs proto to the wrong place.

@faddat faddat merged commit 70ee541 into notional-labs:real-46-branch Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants