Add fail on permissions flag #551
Conversation
| .idea/ | ||
| *.iml |
There was a problem hiding this comment.
Could you add them to your global gitignore instead? Accepting any IDEs makes our gitignore fat and hard to maintain.
| pub fn new( | ||
| inotify: Inotify, | ||
| event_handler: Box<dyn EventHandler>, | ||
| fail_on_no_permissions: bool, |
There was a problem hiding this comment.
I'd prefer passing a config like this via a wrapper (a struct) instead, otherwise args could be too long and we have to expect breaking changes each time we modify.
There was a problem hiding this comment.
yep, please pass the config down if possible
|
|
||
| /// For the [INotifyWatcher](crate::INotifyWatcher) backend. | ||
| /// | ||
| /// This flag sets whether inotify should fail when the user has no permissions on a subfolder. |
There was a problem hiding this comment.
I think this isn't actually true - my guess is you tested this on linux where we have to subscribe to each system ?
That's not the case on windows - not even sure if we would get any errors there. It's correct for the pollwatcher.
| .idea/ | ||
| *.iml |
| pub fn new( | ||
| inotify: Inotify, | ||
| event_handler: Box<dyn EventHandler>, | ||
| fail_on_no_permissions: bool, |
There was a problem hiding this comment.
yep, please pass the config down if possible
See more details here - rust-lang/rust#126195
I ran into a case where, specifically in inotify, if I'm watching a directory and the user does not have permissions on a subdirectory, the watch will fail.
Added a flag in the Config struct to change this behavior (still the default).