Skip to content

Commit

Permalink
Prepare 4.5.1 release
Browse files Browse the repository at this point in the history
  • Loading branch information
noties committed Aug 13, 2020
1 parent 854fa74 commit 6028915
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
8 changes: 5 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
# Changelog

# SNAPSHOT
# 4.5.1

#### Changed
* `image-coil` - use `coil-base` as `api` dependency (would require explicit `coil` dependency)
* `image-coil` - use `coil-base` as `api` dependency (would require explicit `coil` dependency) ([#274])

#### Fixed
* `image-coil` - deliver image result if it loaded before request disposable is created ([#272])
* `ext-tables` - fix column width rounding issue

[#272]: https://github.com/noties/Markwon/issues/272
[#272]: https://github.com/noties/Markwon/issues/272
[#274]: https://github.com/noties/Markwon/issues/274


# 4.5.0

Expand Down
2 changes: 1 addition & 1 deletion markwon-image-coil/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ android {
dependencies {
api project(':markwon-core')

// @since $SNAPSHOT; declare `coil-base` as api dependency (would require users
// @since 4.5.1 declare `coil-base` as api dependency (would require users
// to have explicit coil dependency)
api deps['coil-base']
compileOnly deps['coil']
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public void load(@NonNull AsyncDrawable drawable) {
final LoadRequest request = coilStore.load(drawable).newBuilder()
.target(target)
.build();
// @since $SNAPSHOT; execute can return result _before_ disposable is created,
// @since 4.5.1 execute can return result _before_ disposable is created,
// thus `execute` would finish before we put disposable in cache (and thus result is
// not delivered)
final RequestDisposable disposable = imageLoader.execute(request);
Expand Down Expand Up @@ -168,7 +168,7 @@ private AsyncDrawableTarget(@NonNull AsyncDrawable drawable, @NonNull AtomicBool

@Override
public void onSuccess(@NonNull Drawable loadedDrawable) {
// @since $SNAPSHOT; check finished flag (result can be delivered _before_ disposable is created)
// @since 4.5.1 check finished flag (result can be delivered _before_ disposable is created)
if (cache.remove(drawable) != null
|| !loaded.get()) {
// mark
Expand Down

0 comments on commit 6028915

Please sign in to comment.