687-platform-usage-updates #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because calling `to_date` on a string in 'MM-YYYY'
format will assume that 'MM' is the day, and will set the current month
as 'MM' instead.
params.fetch(:begin_date) => "06-2023"
params.fetch(:begin_date).to_date => Wed, 06 Sep 2023
We are also still allowing for dates to use MM-DD-YYYY format.
'2023-06-10'.match(/(^\d{4}-\d{2}$)|(^\d{4}-\d{2}-\d{2}$)/)
=> #<MatchData "2023-06-10" 1:nil 2:"2023-06-10">
'2023-06'.match(/(^\d{4}-\d{2}$)|(^\d{4}-\d{2}-\d{2}$)/)
=> #<MatchData "2023-06" 1:"2023-06" 2:nil>
'06-2023'.match(/(^\d{4}-\d{2}$)|(^\d{4}-\d{2}-\d{2}$)/)
=> nil
ref: #687 (comment)
alishaevn
commented
Sep 27, 2023
exception 0 is a special case, as it represents info or debugging messages. when the query is successful, despite the exception, the exception is to be returned as part of the report header. ref: https://countermetrics.stoplight.io/docs/counter-sushi-api/jmelferytrixm-exception-0 ref: #687 (comment)
alishaevn
commented
Sep 28, 2023
| # params.fetch(:begin_date).to_date => Wed, 06 Sep 2023 | ||
| def validate_date_format(dates = []) | ||
| dates.each do |date| | ||
| match = date.match(/(^\d{4}-\d{2}$)|(^\d{4}-\d{2}-\d{2}$)/) |
There was a problem hiding this comment.
'2023-06-10'.match(/(^\d{4}-\d{2}$)|(^\d{4}-\d{2}-\d{2}$)/) => #<MatchData "2023-06-10" 1:nil 2:"2023-06-10">
'2023-06'.match(/(^\d{4}-\d{2}$)|(^\d{4}-\d{2}-\d{2}$)/) => #<MatchData "2023-06" 1:"2023-06" 2:nil>
'06-2023'.match(/(^\d{4}-\d{2}$)|(^\d{4}-\d{2}-\d{2}$)/) => nil
There was a problem hiding this comment.
Can you write tests for these? Regular expressions are notorious for missing use cases.
There was a problem hiding this comment.
@jeremyf other than the two specs in sushi_spec.rb?
There was a problem hiding this comment.
Ugh, I completely mentally skipped over those.
jeremyf
suggested changes
Sep 28, 2023
| # params.fetch(:begin_date).to_date => Wed, 06 Sep 2023 | ||
| def validate_date_format(dates = []) | ||
| dates.each do |date| | ||
| match = date.match(/(^\d{4}-\d{2}$)|(^\d{4}-\d{2}-\d{2}$)/) |
There was a problem hiding this comment.
Can you write tests for these? Regular expressions are notorious for missing use cases.
jeremyf
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
first issue
accounting for begin/end dates passed as
MM/YYYY.This is necessary because calling
to_dateon a string inMM-YYYYformat will assume thatMMis the day, and will set the current month asMMinstead.We are also still allowing for dates to use
MM-DD-YYYYformat.second issue
accounting for exceptions in the report header
exception 0 is a special case, as it represents info or debugging messages.
when the query is successful, despite the exception, the exception is
to be returned as part of the report header.
ref: https://countermetrics.stoplight.io/docs/counter-sushi-api/jmelferytrixm-exception-0
ref: #687 (comment)
Screenshots / Video
MM-YYYY format
YYYY-MM-DD format