searches_platform sushi filter #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Searches_Platform` is a valid metric_type filter according to https://countermetrics.stoplight.io/docs/counter-sushi-api/3wikuuhv4hnbv-pr-report-filters. before this commit we were always returning `Searches_Platform`, despite whether a `metric_type` filter was being used. with this commit, we only return `Searches_Platform` if the `metric_type` param includes it, or is not being passed at all. ref: #686 (comment)
`Searches_Platform` is a valid metric_type filter according to https://countermetrics.stoplight.io/docs/counter-sushi-api/xggfvq5by3gx0-pr-p1-report-filters. before this commit we were always returning `Searches_Platform`, despite whether a `metric_type` filter was being used. with this commit, we only return `Searches_Platform` if the `metric_type` param includes it, or is not being passed at all. ref: #687 (comment)
alishaevn
commented
Sep 27, 2023
| @@ -125,6 +128,8 @@ def attribute_performance_for_resource_types | |||
| end | |||
|
|
|||
| def attribute_performance_for_platform | |||
| return [] if metric_type_in_params && metric_types.exclude?("Searches_Platform") | |||
There was a problem hiding this comment.
# no param (nil && false => nil) (nil != false, so we don't return)
# with param other than searches (true && true => true)
# with searches param (true && false => false)
jeremyf
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
update filter handling for the platform and platform usage reports
Searches_Platformis a valid metric_type filter according tohttps://countermetrics.stoplight.io/docs/counter-sushi-api/3wikuuhv4hnbv-pr-report-filters and https://countermetrics.stoplight.io/docs/counter-sushi-api/xggfvq5by3gx0-pr-p1-report-filters.
Expected Behavior Before Changes
we were always returning
Searches_Platform, despite whether ametric_typefilter was being used.Expected Behavior After Changes
we only return
Searches_Platformif themetric_typeparam includes it, or is not being passed at all.Screenshots / Video
platform report
no
metric_typeparamwith
metric_type=searches_platformparamwith
metric_type=xxxparamplatform usage report
no
metric_typeparamwith
metric_type=searches_platformparamwith
metric_type=xxxparamNotes