Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add support for armv7 binary release #956

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

lmussier
Copy link
Contributor

@lmussier lmussier commented Jun 3, 2024

Modify targeted goarch and ignore irelevant configs (e.g windows / arm and darwi n/ arm)

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.87%. Comparing base (b6dca32) to head (fcd61e3).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
+ Coverage   71.34%   71.87%   +0.52%     
==========================================
  Files          45       46       +1     
  Lines        2174     2229      +55     
==========================================
+ Hits         1551     1602      +51     
- Misses        429      431       +2     
- Partials      194      196       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT shizhMSFT changed the title Add support for armv7 binary release build: add support for armv7 binary release Jun 4, 2024
@shizhMSFT
Copy link
Contributor

@lmussier Could you fix the DCO check?

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself LGTM but the DCO needs to be fixed.

@FeynmanZhou FeynmanZhou linked an issue Jun 4, 2024 that may be closed by this pull request
@FeynmanZhou
Copy link
Member

@lmussier Thanks for your contribution. You may refer to this doc to fix the DCO issue and submit signed git commit: https://github.com/notaryproject/.github/blob/main/CONTRIBUTING.md#commit

@lmussier
Copy link
Contributor Author

lmussier commented Jun 4, 2024

@lmussier Could you fix the DCO check?

I'll do.

@lmussier lmussier force-pushed the main branch 2 times, most recently from 32e8a23 to ff9b906 Compare June 4, 2024 11:20
Signed-off-by: lmussier <ludovic.mussier@gmail.com>
@lmussier
Copy link
Contributor Author

lmussier commented Jun 4, 2024

Should be good know.

@lmussier
Copy link
Contributor Author

Hi @notaryproject/notaryproject-notation-maintainers anything I have to do to retrigger a DCO check - I lmight have missed something also...

@shizhMSFT shizhMSFT marked this pull request as draft July 2, 2024 06:30
@shizhMSFT shizhMSFT marked this pull request as ready for review July 2, 2024 06:30
@shizhMSFT
Copy link
Contributor

@lmussier Could you force push again to fix the DCO issue? It hangs because of the GitHub bugs at that time.

@JeyJeyGao
Copy link
Contributor

@lmussier Could you try this comment to generate a new commit id and push it again. Thanks!

git commit --amend --no-edit

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmussier lmussier force-pushed the main branch 2 times, most recently from d9788e8 to ec15b08 Compare July 16, 2024 14:16
@lmussier
Copy link
Contributor Author

lmussier commented Jul 16, 2024

@JeyJeyGao

@lmussier Could you try this comment to generate a new commit id and push it again. Thanks!

git commit --amend --no-edit

Done but might have messedup the signature, this new commit is not 'verified' for github.
But DCO i shappy, I guess it ok then.
(and sorry for the delay, notifications are no well handeled on my side...)

@JeyJeyGao
Copy link
Contributor

@lmussier Please try:

git commit --amend --no-edit -S

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Jul 23, 2024

@lmussier The PR is approved but merging is blocked since ec15b08 is not signed properly. Could you sign that commit so that we can merge this PR?

…darwin

Signed-off-by: lmussier <ludovic.mussier@gmail.com>
@priteshbandi priteshbandi merged commit 45b123b into notaryproject:main Jul 24, 2024
7 checks passed
@Two-Hearts Two-Hearts mentioned this pull request Aug 20, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could you add Arm 32 in official release artefacts?
5 participants