feat: notation plugin uninstall command #832
Closed
+219
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Two-Hearts
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT and
SteveLasker
as code owners
Two-Hearts
changed the title
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
==========================================
+ Coverage 64.05% 64.39% +0.33%
==========================================
Files 40 42 +2
Lines 2323 2390 +67
==========================================
+ Hits 1488 1539 +51
- Misses 709 720 +11
- Partials 126 131 +5 ☔ View full report in Codecov by Sentry. |
shizhMSFT
reviewed
Nov 20, 2023
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
…tion into plugin-uninstall
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Nov 23, 2023
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
reviewed
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the spec PR: #809
It adds the
notation plugin uninstallcommand.Tests: The e2e test cases are also included in this PR.
Note: This PR depends on the notation-go PR: notaryproject/notation-go#363Update: PR notaryproject/notation-go#363 has been merged.