update: refactored notation list command #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
patrickzheng200
requested review from
shizhMSFT,
JeyJeyGao,
priteshbandi and
rgnote
Codecov Report
@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 32.14% 32.33% +0.19%
==========================================
Files 25 25
Lines 1341 1336 -5
==========================================
+ Hits 431 432 +1
+ Misses 898 892 -6
Partials 12 12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
patrickzheng200
added
enhancement
priteshbandi
approved these changes
Dec 15, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
vaninrao10
pushed a commit
to vaninrao10/notation
that referenced
this pull request
Jan 3, 2023
This PR refactors the `notation list` command reducing the number of calls to getSignatureRepository() and repo.Resolve(). Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10
pushed a commit
to vaninrao10/notation
that referenced
this pull request
Jan 5, 2023
This PR refactors the `notation list` command reducing the number of calls to getSignatureRepository() and repo.Resolve(). Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10
pushed a commit
to vaninrao10/notation
that referenced
this pull request
Jan 5, 2023
This PR refactors the `notation list` command reducing the number of calls to getSignatureRepository() and repo.Resolve(). Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
notation listcommand reducing the number of calls to getSignatureRepository() and repo.Resolve().