Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update runner version to ubuntu-24.04 #1140

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Jan 13, 2025

CI:

  • Updated the runner version to ubuntu-24.04 for release pipeline as ubuntu-20.04 is reaching the end of life on 2025-05-29.

Test:

  • goreleaser works well in forked repo

Reference: https://en.wikipedia.org/wiki/Ubuntu_version_history#2004
Resolves #1139

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.79%. Comparing base (fd00032) to head (d3cd122).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1140   +/-   ##
=======================================
  Coverage   70.79%   70.79%           
=======================================
  Files          48       48           
  Lines        2945     2945           
=======================================
  Hits         2085     2085           
  Misses        668      668           
  Partials      192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 5c1842c into notaryproject:main Jan 14, 2025
7 checks passed
@JeyJeyGao JeyJeyGao deleted the ci/update_runner_version branch January 14, 2025 00:21
Two-Hearts pushed a commit to Two-Hearts/notation that referenced this pull request Jan 16, 2025
CI:
- Updated the runner version to `ubuntu-24.04` for release pipeline as
`ubuntu-20.04` is reaching the end of life on 2025-05-29.

Test:
- `goreleaser` works well in forked repo

Reference: https://en.wikipedia.org/wiki/Ubuntu_version_history#2004
Resolves notaryproject#1139

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release workflow agent version
3 participants