Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: timestamping cert chain revocation check during signing from main to release-1.3 branch #1121

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

Two-Hearts
Copy link
Contributor

This PR backports #1094 from main to release-1.3 branch.

This PR targets on release-1.3 branch.

…aryproject#1094)

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts changed the title backport: backport timestamping cert chain revocation check during signing from main to release-1.3 branch backport: timestamping cert chain revocation check during signing from main to release-1.3 branch Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.79%. Comparing base (fae91b7) to head (aa1d4df).
Report is 1 commits behind head on release-1.3.

Files with missing lines Patch % Lines
cmd/notation/sign.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.3    #1121      +/-   ##
===============================================
+ Coverage        70.72%   70.79%   +0.07%     
===============================================
  Files               47       48       +1     
  Lines             2948     2945       -3     
===============================================
  Hits              2085     2085              
+ Misses             670      668       -2     
+ Partials           193      192       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 3351c95 into notaryproject:release-1.3 Dec 29, 2024
7 checks passed
@Two-Hearts Two-Hearts deleted the release-1.3 branch December 29, 2024 11:20
@Two-Hearts Two-Hearts mentioned this pull request Dec 30, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants