Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: upgrade golang version to v1.23 #1019

Merged
merged 4 commits into from
Aug 27, 2024
Merged

bump: upgrade golang version to v1.23 #1019

merged 4 commits into from
Aug 27, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Aug 26, 2024 •
edited
Loading

No description provided.

@Two-Hearts
upgraded to golang v1.23
b2b834d 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
upgraded golang version in e2e test
8cb5711 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov Codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.01%. Comparing base (b683029) to head (a3d5781).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1019   +/-   ##
=======================================
  Coverage   72.01%   72.01%           
=======================================
  Files          46       46           
  Lines        2287     2287           
=======================================
  Hits         1647     1647           
  Misses        440      440           
  Partials      200      200

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

priteshbandi
priteshbandi previously approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vaninrao10
vaninrao10 previously approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency bump up should also be cherry-picked or backported to v1.2.0.

test/e2e/go.mod Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems #538 did the right thing and this PR does not.

@Two-Hearts
upgrade golang to v1.23
7afc4e9 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts dismissed stale reviews from vaninrao10 and priteshbandi via 7afc4e9 August 27, 2024 00:03
@Two-Hearts Two-Hearts changed the title bump: upgrade golang version bump: upgrade golang version to v1.23 Aug 27, 2024
@JeyJeyGao
Copy link
Contributor

what about building.md?

Building above binaries require golang with version >= 1.22.

@Two-Hearts
Copy link
Contributor Author

Two-Hearts commented Aug 27, 2024 •
edited
Loading

what about building.md?

Building above binaries require golang with version >= 1.22.

This should be correct? >= 1.22 includes 1.23. @JeyJeyGao

@shizhMSFT
Copy link
Contributor

what about building.md?

Building above binaries require golang with version >= 1.22.

Good catch. Since go.mod requires 1.23, we should update the building.md for 1.23. This is also for security purposes.

@Two-Hearts
update
a3d5781 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
JeyJeyGao approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 83ade99 into notaryproject:main Aug 27, 2024
7 checks passed
@Two-Hearts Two-Hearts deleted the bump branch August 27, 2024 05:03
@JeyJeyGao JeyJeyGao mentioned this pull request Aug 27, 2024
Closed
Two-Hearts added a commit to Two-Hearts/notation that referenced this pull request Aug 28, 2024
@Two-Hearts
bump: upgrade golang version to v1.23 (notaryproject#1019)
689d753 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts mentioned this pull request Oct 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Two-Hearts @JeyJeyGao @shizhMSFT @priteshbandi @vaninrao10