Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README file #295

Merged
merged 24 commits into from
Nov 10, 2023
Merged

Updated README file #295

merged 24 commits into from
Nov 10, 2023

Conversation

sanjayk0508
Copy link
Contributor

@sanjayk0508 sanjayk0508 commented Jun 29, 2023

This PR contains

Updated the README.md file as requested. It now provides comprehensive information and includes helpful links for new users and contributors.

I have included the necessary points and information proposed by @toddysm. Please let me know if any additional information needs to be added to the README.md file.

#288

Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for notarydev ready!

Name Link
🔨 Latest commit e59243f
🔍 Latest deploy log https://app.netlify.com/sites/notarydev/deploys/6509ed1321ea250008560639
😎 Deploy Preview https://deploy-preview-295--notarydev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@1Shubham7 1Shubham7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the complete very thoroughly and it sounds almost perfect. These are not major changes but do add them if you feel they add some value.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
sanjayk0508 and others added 5 commits July 8, 2023 21:38
Co-authored-by: Samir Kakkar <83560495+iamsamirzon@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Co-authored-by: Samir Kakkar <83560495+iamsamirzon@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Co-authored-by: Samir Kakkar <83560495+iamsamirzon@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Co-authored-by: Samir Kakkar <83560495+iamsamirzon@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Co-authored-by: Samir Kakkar <83560495+iamsamirzon@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
sanjayk0508 and others added 7 commits July 15, 2023 17:52
Co-authored-by: Zach Rhoads <43684271+zr-msft@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Co-authored-by: Zach Rhoads <43684271+zr-msft@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Co-authored-by: Zach Rhoads <43684271+zr-msft@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Co-authored-by: Zach Rhoads <43684271+zr-msft@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Co-authored-by: Zach Rhoads <43684271+zr-msft@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Co-authored-by: Zach Rhoads <43684271+zr-msft@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Co-authored-by: Zach Rhoads <43684271+zr-msft@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Feynman Zhou <feynman@kubesphere.io>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanjayk0508 , suggest updating the overview of Notary Project based on notaryproject/.github#32

README.md Outdated Show resolved Hide resolved
Co-authored-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
iamsamirzon
iamsamirzon previously approved these changes Aug 17, 2023
sanjayk0508 and others added 4 commits August 18, 2023 09:26
Co-authored-by: Samir Kakkar <83560495+iamsamirzon@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
sanjayk0508 and others added 2 commits September 20, 2023 00:17
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
Co-authored-by: Zach Rhoads <43684271+zr-msft@users.noreply.github.com>
Signed-off-by: Sanjay <102804548+sanjayk0508@users.noreply.github.com>
@zr-msft
Copy link
Collaborator

zr-msft commented Sep 19, 2023

@yizha1 @FeynmanZhou can you review this PR please and I'll handle merging

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Nov 10, 2023
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanjayk0508 LGTM

@yizha1 yizha1 merged commit af79ff7 into notaryproject:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants