doc: update contributing guide #25

yizha1 · 2023-04-23T12:30:25Z

Resolve #6

Signed-off-by: Yi Zha yizha1@microsoft.com

Signed-off-by: Yi Zha <yizha1@microsoft.com>

CONTRIBUTING.md

Signed-off-by: Yi Zha <yizha1@microsoft.com>

shizhMSFT

LGTM

Sumitmaithani · 2023-05-12T07:41:52Z

I noticed that the instructions for committing and pushing changes don't include the signoff command, also known as DCO. I think it would be great to add this information to the instructions.

Currently:

git add <files_changed>
git commit -m <commit_message>
git push origin HEAD

Expected:

git add <files_changed>
git commit -s -m <commit_message>
git push origin HEAD

Signed-off-by: Yi Zha <yizha1@microsoft.com>

yizha1 · 2023-05-12T12:15:54Z

I noticed that the instructions for committing and pushing changes don't include the signoff command, also known as DCO. I think it would be great to add this information to the instructions.

Thanks @Sumitmaithani , Please check this section to see whether it solves your problem.

Sumitmaithani · 2023-05-12T12:38:32Z

@yizha1 👍 Looks great!

CONTRIBUTING.md

FeynmanZhou

PTAL

CONTRIBUTING.md

Signed-off-by: Yi Zha <yizha1@microsoft.com>

FeynmanZhou

LGTM for using it as the first version

FeynmanZhou

LGTM

priteshbandi

LGTM

CONTRIBUTING.md

yizha1 · 2023-12-21T01:54:17Z

Thanks for all the comments. I will resolve them before end of 12/22/2023.

Signed-off-by: Yi Zha <yizha1@microsoft.com>

This PR enables the `notation-go` repo to run stale action at 1:30 every day to label or close stale PRs and issues. See guideline https://github.com/marketplace/actions/close-stale-issues This is the definition for stale PRs or issues that we discussed during community call and to be updated in [contributing PR](notaryproject/.github#25). "A stale issue is one that remains inactive or without updates for a period of 60 days. A stale pull request (PR) is one that remains inactive or without updates for a period of 45 days. When an issue or PR becomes stale, it is labelled as `stale`. Normally maintainers will comment on stale issues or PRs to prompt participants to take action. If there is no activity for additional 30 days, this issue or PR will be closed. If an update/comment occur on stale issues or pull requests, the stale label will be removed, and the timer will restart" Signed-off-by: Yi Zha <yizha1@microsoft.com>

This PR enables the `notation` repo to run stale action at 1:30 every day to label or close stale PRs and issues. See guideline https://github.com/marketplace/actions/close-stale-issues This is the definition for stale PRs or issues that we discussed during community call and to be updated in [contributing PR](notaryproject/.github#25). "A stale issue is one that remains inactive or without updates for a period of 60 days. A stale pull request (PR) is one that remains inactive or without updates for a period of 45 days. When an issue or PR becomes stale, it is labelled as `stale`. Normally maintainers will comment on stale issues or PRs to prompt participants to take action. If there is no activity for additional 30 days, this issue or PR will be closed. If an update/comment occur on stale issues or pull requests, the stale label will be removed, and the timer will restart" Signed-off-by: Yi Zha <yizha1@microsoft.com> --------- Signed-off-by: Yi Zha <yizha1@microsoft.com>

This PR enables the `notation-core-go` repo to run stale action at 1:30 every day to label or close stale PRs and issues. See guideline https://github.com/marketplace/actions/close-stale-issues This is the definition for stale PRs or issues that we discussed during community call and to be updated in [contributing PR](notaryproject/.github#25). "A stale issue is one that remains inactive or without updates for a period of 60 days. A stale pull request (PR) is one that remains inactive or without updates for a period of 45 days. When an issue or PR becomes stale, it is labelled as `stale`. Normally maintainers will comment on stale issues or PRs to prompt participants to take action. If there is no activity for additional 30 days, this issue or PR will be closed. If an update/comment occur on stale issues or pull requests, the stale label will be removed, and the timer will restart" Signed-off-by: Yi Zha <yizha1@microsoft.com> --------- Signed-off-by: Yi Zha <yizha1@microsoft.com>

yizha1 · 2024-04-13T03:22:56Z

@priteshbandi @shizhMSFT @FeynmanZhou @toddysm Would you mind reviewing this PR again, which has been open quite a long time?

Please be aware of some updates on the milestone naming according to Toddy's comment to bring more claritiy.

Change Future milestone to backlog milestone
Change Discuss milestone to in dicussion (or maybe we can remove this milestone, but label related issues and PRs need dicussion

shizhMSFT

LGTM

priteshbandi

LGTM

FeynmanZhou

LGTM

This PR enables the `notation-go` repo to run stale action at 1:30 every day to label or close stale PRs and issues. See guideline https://github.com/marketplace/actions/close-stale-issues This is the definition for stale PRs or issues that we discussed during community call and to be updated in [contributing PR](notaryproject/.github#25). "A stale issue is one that remains inactive or without updates for a period of 60 days. A stale pull request (PR) is one that remains inactive or without updates for a period of 45 days. When an issue or PR becomes stale, it is labelled as `stale`. Normally maintainers will comment on stale issues or PRs to prompt participants to take action. If there is no activity for additional 30 days, this issue or PR will be closed. If an update/comment occur on stale issues or pull requests, the stale label will be removed, and the timer will restart" Signed-off-by: Yi Zha <yizha1@microsoft.com>

doc: update contributing guide

ee358af

Signed-off-by: Yi Zha <yizha1@microsoft.com>

yizha1 requested review from FeynmanZhou, gokarnm, justincormack, NiazFK, priteshbandi, SteveLasker, toddysm and vaninrao10 as code owners April 23, 2023 12:30

doc: update labels and issues LCM

d54cf5d

Signed-off-by: Yi Zha <yizha1@microsoft.com>

shizhMSFT reviewed Apr 26, 2023

View reviewed changes

doc: update per comments

aa74beb

Signed-off-by: Yi Zha <yizha1@microsoft.com>

yizha1 requested a review from shizhMSFT April 27, 2023 06:17

shizhMSFT previously approved these changes Apr 27, 2023

View reviewed changes

doc: update per comments

5906ba5

Signed-off-by: Yi Zha <yizha1@microsoft.com>

yizha1 dismissed shizhMSFT’s stale review via 5906ba5 May 12, 2023 12:09

FeynmanZhou reviewed May 15, 2023

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

FeynmanZhou reviewed May 15, 2023

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

FeynmanZhou reviewed May 15, 2023

View reviewed changes

CONTRIBUTING.md Show resolved Hide resolved

FeynmanZhou requested changes May 15, 2023

View reviewed changes

toddysm requested changes May 16, 2023

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

yizha1 mentioned this pull request May 18, 2023

chore: update CONTRIBUTING.md notaryproject/notaryproject.dev#210

Merged

doc: update per comments

b8ec8c4

Signed-off-by: Yi Zha <yizha1@microsoft.com>

yizha1 requested review from FeynmanZhou and toddysm May 20, 2023 11:09

yizha1 mentioned this pull request May 24, 2023

Add conventions to contributing guide #24

Closed

FeynmanZhou approved these changes May 30, 2023

View reviewed changes

FeynmanZhou previously approved these changes Nov 10, 2023

View reviewed changes

priteshbandi previously approved these changes Nov 22, 2023

View reviewed changes

toddysm requested changes Nov 28, 2023

View reviewed changes

upate per Toddy's comments

bf7834d

Signed-off-by: Yi Zha <yizha1@microsoft.com>

yizha1 dismissed stale reviews from priteshbandi and FeynmanZhou via bf7834d December 27, 2023 06:15

yizha1 requested review from toddysm, priteshbandi, FeynmanZhou and shizhMSFT December 27, 2023 06:16

yizha1 dismissed shizhMSFT’s stale review via bf7834d January 18, 2024 03:35

FeynmanZhou mentioned this pull request Jan 30, 2024

Nominate Yi Zha as a Notary Project Org maintainer #67

Closed

yizha1 linked an issue Apr 13, 2024 that may be closed by this pull request

Add conventions to contributing guide #24

Closed

shizhMSFT approved these changes Apr 15, 2024

View reviewed changes

NiazFK approved these changes Apr 18, 2024

View reviewed changes

priteshbandi approved these changes Apr 18, 2024

View reviewed changes

FeynmanZhou approved these changes Apr 19, 2024

View reviewed changes

toddysm approved these changes Apr 19, 2024

View reviewed changes

yizha1 merged commit a70c9c6 into notaryproject:main Apr 20, 2024
1 check passed

yizha1 deleted the contri_guide branch April 20, 2024 01:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: update contributing guide #25

doc: update contributing guide #25

yizha1 commented Apr 23, 2023

shizhMSFT left a comment

Sumitmaithani commented May 12, 2023

yizha1 commented May 12, 2023

Sumitmaithani commented May 12, 2023

FeynmanZhou left a comment

FeynmanZhou left a comment

FeynmanZhou left a comment

priteshbandi left a comment

yizha1 commented Dec 21, 2023

yizha1 commented Apr 13, 2024

shizhMSFT left a comment

priteshbandi left a comment

FeynmanZhou left a comment

doc: update contributing guide #25

doc: update contributing guide #25

Conversation

yizha1 commented Apr 23, 2023

shizhMSFT left a comment

Choose a reason for hiding this comment

Sumitmaithani commented May 12, 2023

yizha1 commented May 12, 2023

Sumitmaithani commented May 12, 2023

FeynmanZhou left a comment

Choose a reason for hiding this comment

FeynmanZhou left a comment

Choose a reason for hiding this comment

FeynmanZhou left a comment

Choose a reason for hiding this comment

priteshbandi left a comment

Choose a reason for hiding this comment

yizha1 commented Dec 21, 2023

yizha1 commented Apr 13, 2024

shizhMSFT left a comment

Choose a reason for hiding this comment

priteshbandi left a comment

Choose a reason for hiding this comment

FeynmanZhou left a comment

Choose a reason for hiding this comment