Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment support in JSON (jsonc) #95

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Add comment support in JSON (jsonc) #95

merged 1 commit into from
Mar 1, 2024

Conversation

wait-what
Copy link
Contributor

@wait-what wait-what commented Feb 26, 2024

Closes #94. This PR adds comment support in the JSON parser. Comments are now ignored instead of causing an error. This should have no effect on valid JSON and adds virtually no overhead.

{
    "a": "b" // inline
    // single line
    /* multi
         line */
}

I have added 4 relevant tests and would appreciate if someone would test some more edge cases I didn't think of.

@knickish
Copy link
Collaborator

@not-fl3 Are you aware of any issues this might cause?

@knickish
Copy link
Collaborator

knickish commented Mar 1, 2024

gonna just go ahead an merge it then

@knickish knickish merged commit e3b56de into not-fl3:master Mar 1, 2024
8 checks passed
@not-fl3
Copy link
Owner

not-fl3 commented Mar 2, 2024

Oh, sorry, I missed this PR, sure, I don't see any issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONC (JSON with comments) support
3 participants