Phase out public-square fork of phpecc #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice work done there with the MR integrating the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paragonie-security has graciously accepted to merge the existing
SchnorrSignatureclass from public-square/phpecc into his well maintained fork of mdanter/ecc, and even went the extra mile of analyzing the code and fixing several side-channel timing attacks in it.His changes even made me notice timing attacks in the secp256k1-nostr-php extension 🫠 Which I'll be ironing out in the next hours.
We should switch to his fork of phpecc and tag a new security patch release of the project ASAP.
paragonie/phpecc#30 (comment)
paragonie/phpecc@66669a7
paragonie/phpecc@fdba22a