Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't stringify magic-wanded protected events in reposts #1679

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Don't stringify magic-wanded protected events in reposts #1679

merged 2 commits into from
Jan 13, 2025

Conversation

pablof7z
Copy link
Member

From #1678

@Aspie96
Copy link

Aspie96 commented Jan 11, 2025

I don't agree with the wording because it seems to imply that if the repost is a protected event then its content should be an empty string.

It doesn't matter whether the repost is protected. What matters is whether the original event, which is being reposted, is.

The event with an empty content isn't the protected one.

staab
staab requested changes Jan 12, 2025
View reviewed changes
@mikedilger
Copy link
Contributor

Implemented in gossip.

pablof7z added a commit to nostr-dev-kit/ndk that referenced this pull request Jan 12, 2025
@pablof7z
avoids distributing events that were NIP-70ed
108a1b4 
nostr-protocol/nips#1679
Aspie96
Aspie96 approved these changes Jan 13, 2025
View reviewed changes
Copy link

@Aspie96 Aspie96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original wording was incorrect. I think this correction clarifies it.

pablof7z added a commit to nostr-dev-kit/ndk that referenced this pull request Jan 13, 2025
@pablof7z
Squashed commit of the following:
e281e8f 
commit 80efbd8
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 13:00:01 2025 +0000

    nutzap monitor hook

commit 42edebf
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 12:58:54 2025 +0000

    be more careful with unpublished events

commit 620c078
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 11:39:02 2025 +0000

    track pools

commit af92e4a
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 11:36:58 2025 +0000

    fix imeta loading in NDKVideo

commit 965bb64
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 11:36:40 2025 +0000

    fix accidental client tag removal

commit 8248e83
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 00:12:28 2025 +0000

    refactor gift wraps to avoid circular dependencies

commit ddb82d1
Author: pablof7z <pfer@me.com>
Date:   Sun Jan 12 23:40:21 2025 +0000

    wip

commit 99fe7af
Author: pablof7z <pfer@me.com>
Date:   Sun Jan 12 22:45:03 2025 +0000

    doc fixes

commit 108a1b4
Author: pablof7z <pfer@me.com>
Date:   Fri Jan 10 08:40:10 2025 -0600

    avoids distributing events that were NIP-70ed

    nostr-protocol/nips#1679

commit b974b71
Author: Pablo Fernandez <p@f7z.io>
Date:   Sun Jan 12 21:17:58 2025 +0000

    normalize opt

commit 597a92a
Author: DanConwayDev <114834599+DanConwayDev@users.noreply.github.com>
Date:   Sun Jan 12 21:16:40 2025 +0000

    add subscription option: dont save to cache (#241)

    so that, optionally, only events from important subscriptions are
    retained in the cache to keep it lean and mean, like a venison steak

    Co-authored-by: Pablo Fernandez <p@f7z.io>

commit 2263f32
Author: Vivek Ganesan <caliberoviv@gmail.com>
Date:   Mon Jan 13 02:43:29 2025 +0530

    Correct the ndk wallet usage instructions (#292)

commit 82b60c3
Author: rodant <rodant68@gmail.com>
Date:   Sun Jan 12 22:12:56 2025 +0100

    Add GiftWrap and NIP-17 DMs (#279)

    * rename nip04.ts to encryption.ts

    * implement nip44 as optional encryption nip for signers

    * UNTESTED implement nip44 as optional encryption for NDKPrivateSigner

    UNTESTED with a test written

    * BUGFIX wrong import and wrong privateKey params

    * ADDED Nip44 support for NDKNip07Signer

    also some buigfiixes for encryptionEnabled()
    UNTESTED : this commit has not been tested yet.

    * UNTESTED adds Nip59 giftWrap and giftUnwrap for NDKEvents

    * ADDED tests to encryption.test.ts

    coppied Nip44 test for encrypt and decrypt
    new Nip59 test for gift wrap and unwrap

    * UPDATE add encryoption kinds to NDKKind enum

    * Fix compile errors matching current master of upstream ndk repo.

    * Fix compile errors.

    * Revert dev dependency changes.

    * Fallback to original pnpm-lock file.

    * Extract gift-wrapping from encryption.ts

    * Fix MAC error in encryption test.

    * Add tests for Nip07 signer and refactorings.

    * Small refactoring.

    * Support for Nip46 signers and unit tests for that.

    * Test for forced Nip04 encryption and bug fixing.

    * Nip17 encryption methods and more tests.

    * Fix some of the review comments.

    * Changes after review from @pablof7z.

    ---------

    Co-authored-by: manimejia <noreply@manimejia.me>
pablof7z added a commit to nostr-dev-kit/ndk that referenced this pull request Jan 13, 2025
@pablof7z
Squashed commit of the following:
43aefaf 
commit ba5be49
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 13:06:26 2025 +0000

    refactor wip

commit 80efbd8
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 13:00:01 2025 +0000

    nutzap monitor hook

commit 42edebf
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 12:58:54 2025 +0000

    be more careful with unpublished events

commit 620c078
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 11:39:02 2025 +0000

    track pools

commit af92e4a
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 11:36:58 2025 +0000

    fix imeta loading in NDKVideo

commit 965bb64
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 11:36:40 2025 +0000

    fix accidental client tag removal

commit 8248e83
Author: pablof7z <pfer@me.com>
Date:   Mon Jan 13 00:12:28 2025 +0000

    refactor gift wraps to avoid circular dependencies

commit ddb82d1
Author: pablof7z <pfer@me.com>
Date:   Sun Jan 12 23:40:21 2025 +0000

    wip

commit 99fe7af
Author: pablof7z <pfer@me.com>
Date:   Sun Jan 12 22:45:03 2025 +0000

    doc fixes

commit 108a1b4
Author: pablof7z <pfer@me.com>
Date:   Fri Jan 10 08:40:10 2025 -0600

    avoids distributing events that were NIP-70ed

    nostr-protocol/nips#1679

commit b974b71
Author: Pablo Fernandez <p@f7z.io>
Date:   Sun Jan 12 21:17:58 2025 +0000

    normalize opt

commit 597a92a
Author: DanConwayDev <114834599+DanConwayDev@users.noreply.github.com>
Date:   Sun Jan 12 21:16:40 2025 +0000

    add subscription option: dont save to cache (#241)

    so that, optionally, only events from important subscriptions are
    retained in the cache to keep it lean and mean, like a venison steak

    Co-authored-by: Pablo Fernandez <p@f7z.io>

commit 2263f32
Author: Vivek Ganesan <caliberoviv@gmail.com>
Date:   Mon Jan 13 02:43:29 2025 +0530

    Correct the ndk wallet usage instructions (#292)

commit 82b60c3
Author: rodant <rodant68@gmail.com>
Date:   Sun Jan 12 22:12:56 2025 +0100

    Add GiftWrap and NIP-17 DMs (#279)

    * rename nip04.ts to encryption.ts

    * implement nip44 as optional encryption nip for signers

    * UNTESTED implement nip44 as optional encryption for NDKPrivateSigner

    UNTESTED with a test written

    * BUGFIX wrong import and wrong privateKey params

    * ADDED Nip44 support for NDKNip07Signer

    also some buigfiixes for encryptionEnabled()
    UNTESTED : this commit has not been tested yet.

    * UNTESTED adds Nip59 giftWrap and giftUnwrap for NDKEvents

    * ADDED tests to encryption.test.ts

    coppied Nip44 test for encrypt and decrypt
    new Nip59 test for gift wrap and unwrap

    * UPDATE add encryoption kinds to NDKKind enum

    * Fix compile errors matching current master of upstream ndk repo.

    * Fix compile errors.

    * Revert dev dependency changes.

    * Fallback to original pnpm-lock file.

    * Extract gift-wrapping from encryption.ts

    * Fix MAC error in encryption test.

    * Add tests for Nip07 signer and refactorings.

    * Small refactoring.

    * Support for Nip46 signers and unit tests for that.

    * Test for forced Nip04 encryption and bug fixing.

    * Nip17 encryption methods and more tests.

    * Fix some of the review comments.

    * Changes after review from @pablof7z.

    ---------

    Co-authored-by: manimejia <noreply@manimejia.me>
@pablof7z @staab
Update 18.md
d96f6f8 
Co-authored-by: hodlbod <jstaab@protonmail.com>
@pablof7z pablof7z merged commit 0f376a7 into master Jan 13, 2025
@pablof7z pablof7z deleted the reposted-70s branch January 13, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staab staab staab requested changes

@fiatjaf fiatjaf fiatjaf approved these changes

@Aspie96 Aspie96 Aspie96 approved these changes

@AsaiToshiya AsaiToshiya AsaiToshiya approved these changes

@kehiy kehiy kehiy approved these changes

@anurag-lint anurag-lint anurag-lint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pablof7z @Aspie96 @mikedilger @fiatjaf @staab @AsaiToshiya @kehiy @anurag-lint