fix(parsers/oneOf): halt at reaching eoi

norskeld · Jan 5, 2023 · b20f2a2 · b20f2a2
1 parent 992acee
commit b20f2a2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/__tests__/parsers/oneOf.spec.ts b/src/__tests__/parsers/oneOf.spec.ts
@@ -1,4 +1,5 @@
-import { oneOf } from '@parsers'
+import { sequence } from '@combinators'
+import { string, oneOf } from '@parsers'
 import { run, result, should, describe, testFailure, it } from '@testing'
 
 describe('oneOf', () => {
@@ -12,4 +13,8 @@ describe('oneOf', () => {
   it('should fail if input character is not among given ones', () => {
     testFailure('q-combinator', oneOf('xyz'))
   })
+
+  it('should fail if reached the end of input', () => {
+    testFailure('prefix', sequence(string('prefix'), oneOf('XY')))
+  })
 })
diff --git a/src/parsers/oneOf.ts b/src/parsers/oneOf.ts
@@ -12,6 +12,14 @@ export function oneOf(chars: string): Parser<string> {
 
   return {
     parse(input, pos) {
+      if (input.length === pos) {
+        return {
+          isOk: false,
+          pos,
+          expected: 'oneOf @ reached the end of input'
+        }
+      }
+
       const nextPos = pos + 1
       const char = input.substring(pos, nextPos)