Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate py3.6 #780

Merged
merged 7 commits into from
Feb 20, 2022
Merged

Deprecate py3.6 #780

merged 7 commits into from
Feb 20, 2022

Conversation

ubaumann
Copy link
Contributor

  • remove python 3.6 support
  • update dependencies
  • add python 3.10

ubaumann
ubaumann commented Feb 18, 2022
View reviewed changes
pyproject.toml
nornir-utils = "0.1.2"
nornir-napalm = "0.1.2"
# due to https://github.com/google/textfsm/issues/63
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktbyers This is fixed in version 1.1.2 right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is fixed in >= 1.1.2 (so we should require at least textfsm version 1.1.2 in the dev-dependencies).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I did on line 74
textfsm = "^1.1.2"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, my bad...missed it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have made the comment on line. 74. I had in mind it shows 2 lines before and after

@ubaumann ubaumann mentioned this pull request Feb 18, 2022
Closed
@dbarrosop
Copy link
Contributor

Amazing work

@dbarrosop dbarrosop merged commit 33076fa into nornir-automation:develop Feb 20, 2022
@ubaumann ubaumann deleted the deprecate_py3.6 branch February 20, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktbyers ktbyers ktbyers left review comments

@dbarrosop dbarrosop dbarrosop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ubaumann @dbarrosop @ktbyers