Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pygments because of vulnerabilities #732

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Update pygments because of vulnerabilities #732

merged 3 commits into from
Oct 27, 2021

Conversation

ubaumann
Copy link
Contributor

Updating pygments because of two vulnerabilities

Minumum version would be 2.7.4 but I guess we can update direclty to 2.10.0?

@dbarrosop
Copy link
Contributor

Thanks for the PR. Yes, I think updating to the latest versionwould be fine, however, we are going to have to re-run and save the notebooks as looks like the rendering is slightly different and tests are failing.

Also, note that these vulnerabilities are not exploitable as we only use pygments to render jupyter notebooks for documentation purposes and we control the code rendered.

@ubaumann
Copy link
Contributor Author

Yes I saw. Forgot to run it locally. Did only make pytest.
I should have time in around 5 hours to do it well

@dbarrosop
Copy link
Contributor

No worries and no rush, thanks again :)

@ubaumann
Copy link
Contributor Author

I run the jupyter notebooks and rebased the branch

@ubaumann
Copy link
Contributor Author

Sorry for all the spam. I rerun them in docker. Now it should be fine.

@dbarrosop
Copy link
Contributor

Awesome work. Thanks for this!

@dbarrosop dbarrosop merged commit 9e674c7 into nornir-automation:develop Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants