Do not store failed connections in host attributes #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmfigol
changed the title
dbarrosop
reviewed
Mar 23, 2020
dbarrosop
reviewed
Mar 23, 2020
nornir/core/inventory.py
Outdated
|
|
||
| self.connections.pop(connection).close() | ||
| connection = self.connections.pop(conn_name) |
There was a problem hiding this comment.
this should actually trip mypy. You are storing a type of some sort in a variable that was previously defined as a str so maybe it's better to skip the conn_name and rename this to conn = self.connections.pop(conn_name)
|
Excellent work, just a couple of minor comments but I am pre-approving it as they are very minor |
dbarrosop
approved these changes
Mar 23, 2020
dmfigol
force-pushed
the
fix-failed-connection
branch
from
e1f4c07
to
fbe8b35
Compare
|
Awesome, thanks! |
dbarrosop
pushed a commit
that referenced
this pull request
Sep 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix failed connections are not stored in
host.connectionsdictionary, which means we are not trying to close them, raising an exception.Besides fixing bug #350, this also now allows to have a transparent retry mechanism for tasks which work with connections. Previously, any retry on the host, connection to which has failed, would leave a connection attribute uninitialized and ultimately fail.