Added functions to retrieve inventory using native datastructures #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarrosop
reviewed
Apr 11, 2019
dbarrosop
reviewed
Apr 11, 2019
dbarrosop
reviewed
Apr 11, 2019
|
Looks good, just a few minor comments to make the code more efficient. |
|
@dbarrosop , I believe I have addressed your changes. Let me know if there's anything else. Thanks |
dbarrosop
approved these changes
Apr 22, 2019
|
Awesome! |
dbarrosop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functions to nornir.core.inventory.Inventory to abstract serialization of the running inventory into dictionaries. Functions for: full inventory, defaults, groups, and hosts. This makes the inventory available in an exportable format that users could then build plugins to push out into various formats.
A simple future usecase would be to leverage the dicts to export to simple inventory files. This would allow dynamically added inventory items to be captured and placed into a more permanent inventory.