Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for enum34 and netmiko-poetry issue #322

Merged
merged 2 commits into from
Feb 17, 2019

Conversation

ktbyers
Copy link
Collaborator

@ktbyers ktbyers commented Feb 16, 2019

Testing if this fixes unit tests.

@bradh11
Copy link
Contributor

bradh11 commented Feb 16, 2019

Interesting. What is the nbval test checking? That change should be benign in terminal based usage. Right?

@ktbyers
Copy link
Collaborator Author

ktbyers commented Feb 16, 2019

@bradh11 The nbval test is testing some Python notebooks and actually looks at the exact output including color (so I think the color output has changed here).

@bradh11
Copy link
Contributor

bradh11 commented Feb 16, 2019

Is it testing via ipython or Jupyter (or other)? I can do some research to see if different behavior is expected in that type of environment.

@ktbyers
Copy link
Collaborator Author

ktbyers commented Feb 16, 2019

It is failing on these Jupyter Notebook's:

https://github.com/nornir-automation/nornir/tree/develop/docs/howto

This is the basis for parts of these docs:

https://nornir.readthedocs.io/en/stable/howto/handling_connections.html

@ktbyers
Copy link
Collaborator Author

ktbyers commented Feb 16, 2019

@dbarrosop @dmfigol I think we should incorporate the pyproject.toml and .lock file fixes specified here so that the tests and the development environment start working again.

This will give me additional time to get a new Netmiko release pushed to pypi.

Not sure what we want to do about the colorama issue i.e. whether we want to roll it back here (so the tests start working again)? I only looked at the colorama issue briefly.

@ktbyers ktbyers changed the title Do Not Merge: Temporary fix for enum34 and netmiko-poetry issue Temporary fix for enum34 and netmiko-poetry issue Feb 16, 2019
@dbarrosop
Copy link
Contributor

Not sure what we want to do about the colorama issue i.e. whether we want to roll it back here (so the tests start working again)?

Yes, let's revert it and investigate in parallel. @bradh11 can you do that?

This will give me additional time to get a new Netmiko release pushed to pypi.

LGTM

@bradh11
Copy link
Contributor

bradh11 commented Feb 17, 2019

I probably wont have time to get to it until end of the week, but yes I can research it and let you know my findings. Can you re-open 319?

@dbarrosop
Copy link
Contributor

Thanks, just reopened it.

@dmfigol
Copy link
Collaborator

dmfigol commented Feb 17, 2019

LGTM

@ktbyers ktbyers merged commit c45a0a8 into nornir-automation:develop Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants