Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and deprecate dict() function #314

Merged
merged 4 commits into from
Jan 24, 2019
Merged

fix and deprecate dict() function #314

merged 4 commits into from
Jan 24, 2019

Conversation

dbarrosop
Copy link
Contributor

Fixes #311

@dbarrosop dbarrosop mentioned this pull request Jan 12, 2019
Closed
@dbarrosop
Copy link
Contributor Author

@ktbyers @dmfigol is this one good? I'd like to merge and release soon

@dmfigol
Copy link
Collaborator

dmfigol commented Jan 23, 2019

LGTM

@dbarrosop
Copy link
Contributor Author

Thanks!

@dbarrosop dbarrosop merged commit 701136f into develop Jan 24, 2019
@dbarrosop dbarrosop deleted the dict branch August 3, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmfigol dmfigol dmfigol left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbarrosop @dmfigol