Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix order of preference when deserializing config #309

Merged
merged 4 commits into from
Mar 3, 2019
Merged

fix order of preference when deserializing config #309

merged 4 commits into from
Mar 3, 2019

Conversation

dbarrosop
Copy link
Contributor

No description provided.

@dbarrosop dbarrosop mentioned this pull request Jan 6, 2019
Open
@dbarrosop
Copy link
Contributor Author

@ktbyers @dmfigol can I get a review here? I'd like to merge and release soon

@dmfigol
Copy link
Collaborator

dmfigol commented Jan 23, 2019

@dbarrosop could you briefly describe what this PR is supposed to do so that it is easier to review? I tried following #291 but at some point I gave up.

@dbarrosop
Copy link
Contributor Author

It's basically a bugfix. In the documentation we state that the order of preference of the configuration is config_file < env variables < code, however, that wasn't true after the move to pydantic. This fixes the issue and makes the order correct.

@dbarrosop dbarrosop merged commit c39297c into develop Mar 3, 2019
@dbarrosop dbarrosop deleted the fix_config_preference branch March 3, 2019 12:06
@dbarrosop dbarrosop mentioned this pull request Mar 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbarrosop @dmfigol