Convert SVG images to PNG and use it in manifest and markdown files #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcticicestudio
added
hacktoberfest
1 task
The new VS Code publishing contraints won't allow SVG images from not authorized sources/URLs. This commit makes use of the changes merged in nordtheme/nord#50. nordthemeGH-55
The favicon in the README copyright footer line is not allowed to be loaded from a non-HTTPS URL due to the new VS Code publishing contraints. nordthemeGH-55
arcticicestudio
approved these changes
Oct 10, 2017
There was a problem hiding this comment.
Thanks for your contribution 👍
Nice change with the srcset on the <img> tags!
I've added a PNG formatted footer mountain banner in nordtheme/nord#50 and updated this PR to it. I've also removed the favicon.ico for now until my server gets HTTPS support via the Let’s Encrypt project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does following;
nord-visual-studio-code-icon-marketplace.svg(128x128px & original 257x257px for 2x)nord-visual-studio-code-banner.svg(888x200px & 1776x400px for 2x)package.jsonbadgesinpackage.jsonto use HTTPSREADME.md&CHANGELOG.mdto use PNG image for banner (and also support high-DPI screens usingsrcsetattribute)README.md&CHANGELOG.mdto point to HTTPS URLs.Things to note:
Packing this extension for sideloading using
vscethrows two errors;README.md#L122for using SVG image instead of PNG, which is outside this project and requires to be fixed.README.md#L124for using HTTP URL for.icopath.Closes #55