Fix broken image links #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several broken links. They all pointed to a `develop` branch in the nord-docs repo, which seems to no longer exist. The paths were updated to point to the images on the `main` branch instead.
svengreb
approved these changes
Oct 8, 2022
There was a problem hiding this comment.
Hi @jakeoeding 👋, thanks for your contribution 👍
This is caused by the recent GitHub flow migration in the nord-docs repository as well as the switch from the master to main branch. This is also in preparation for a very big change that is scheduled to be announced in a few weeks which require the paths to be updated again, but in the meantime these should definitely be fixed in almost all Nord port repositories.
|
This update is not reflected in the vs code / microsoft marketplace. the image links are still broken and pointing to the old https://marketplace.visualstudio.com/items?itemName=arcticicestudio.nord-visual-studio-code
|
|
@svengreb I think a publish may be needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several broken links. They all pointed to a
developbranch in the nord-docs repo, which seems to no longer exist. The paths were updated to point to the images on themainbranch instead.