fix npm install #190
Merged
fix npm install #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch to @arcticicestudio/eslint-config-base
svengreb
approved these changes
Jan 31, 2021
arcticicestudio
approved these changes
Jan 31, 2021
There was a problem hiding this comment.
Hi @kremalicious 👋, thanks for your contribution 👍
This sounds like some of the previous NPM policies changed after they joined GitHub. Normally the package should never be unpublished but show a deprecation warning instead.
Doesn't matter now, the replacing the package was the main goal of the deprecation anyway 😄
I'll merge this PR and try to deploy a new release version today so that all package registries are also include this change.
arcticicestudio
pushed a commit
that referenced
this pull request
Feb 1, 2021
Before the `eslint-config-arcticicestudio-base` NPM package [1] was used which has been deprecated and somehow also deleted from the registry after NPM joined GitHub. Since the goal of the deprecation was to move to the new `@arcticicestudio/eslint-config-base` package anyway it has now been switched. [1]: https://www.npmjs.com/package/eslint-config-arcticicestudio-base [2]: https://www.npmjs.com/package/@arcticicestudio/eslint-config-base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arcticicestudio/eslint-config-basein dependenciesSeems
eslint-config-arcticicestudio-basewas removed from the npm registry breaking all installations of this project, either locally or when added as a dependency inpackage.json. This PR switches to the@arcticicestudio/eslint-config-basepackage to fix that.