Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor title border #177

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Editor title border #177

merged 1 commit into from
Jun 20, 2020

Conversation

arcticicestudio
Copy link
Contributor

Resolves #176

@arcticicestudio
Editor title border
bd6016c 
VS Code 1.45 [1] (April 2020) introduced new theme keys for render a
border below the editor group header [2] (for example, below breadcrumbs
if enabled) to restore the previous behavior of
`editorGroupHeader.tabsBorder`.

This commits adapts the new theme key to match the style of
`editorGroupHeader.tabsBorder`.

[1]: https://code.visualstudio.com/updates/v1_45
[2]: https://code.visualstudio.com/updates/v1_45#_new-theme-color-for-editor-title-borde

GH-176
@arcticicestudio arcticicestudio added this to the Next milestone Jun 20, 2020
@arcticicestudio arcticicestudio requested a review from svengreb June 20, 2020 11:36
@arcticicestudio arcticicestudio merged commit c2aca53 into develop Jun 20, 2020
@arcticicestudio arcticicestudio deleted the feature/gh-176-editor-title-border branch June 20, 2020 12:44
arcticicestudio added a commit that referenced this pull request Jun 23, 2020
@arcticicestudio
Editor title border (#177)
f6d5ea5 
VS Code 1.45 [1] (April 2020) introduced new theme keys for render a
border below the editor group header [2] (for example, below breadcrumbs
if enabled) to restore the previous behavior of
`editorGroupHeader.tabsBorder`.

This commits adapts the new theme key to match the style of
`editorGroupHeader.tabsBorder`.

[1]: https://code.visualstudio.com/updates/v1_45
[2]: https://code.visualstudio.com/updates/v1_45#_new-theme-color-for-editor-title-borde

Resolves GH-176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-ui scope-compatibility type-feature
Projects
None yet
Milestone
version-0.15.0
Development

Successfully merging this pull request may close these issues.

Editor title border
2 participants
@arcticicestudio @svengreb