-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax highlighting for Elixir module names and atoms #166
Merged
arcticicestudio
merged 2 commits into
nordtheme:develop
from
feliperenan:frg-improve-elixir-support
Dec 23, 2019
Merged
Syntax highlighting for Elixir module names and atoms #166
arcticicestudio
merged 2 commits into
nordtheme:develop
from
feliperenan:frg-improve-elixir-support
Dec 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliperenan
changed the title
Improve Elixir support
Add Elixir highlight for module names and atoms.
Dec 1, 2019
Fix: #165 Improve Elixir support adding syntax highlight to atoms and module names using `vscode-elixir-lis` patterns. References: https://github.com/JakeBecker/vscode-elixir-ls https://github.com/JakeBecker/vscode-elixir-ls/blob/master/syntaxes/elixir.json
feliperenan
changed the title
Add Elixir highlight for module names and atoms.
Add Elixir syntax highlight for module names and atoms.
Dec 1, 2019
Hi @feliperenan 👋, thanks for your contribution 👍 |
This documents that the added scopes are only available for the specific extension with the given ID and not supported by VSCode out-of-the-box. GH-165
svengreb
approved these changes
Dec 23, 2019
arcticicestudio
approved these changes
Dec 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arcticicestudio
changed the title
Add Elixir syntax highlight for module names and atoms.
Syntax highlighting for Elixir module names and atoms
Dec 23, 2019
arcticicestudio
pushed a commit
that referenced
this pull request
Dec 23, 2019
Improved syntax highlighting for Elixir atoms and module names using scopes provided by the JakeBecker.elixir-ls [1,2,3] extension. The scopes also include the VSCode extension ID to document that the added scopes are only available for the specific extension with the given ID and not supported by VSCode out-of-the-box. [1]: https://marketplace.visualstudio.com/items?itemName=JakeBecker.elixir-ls [2]: https://github.com/JakeBecker/vscode-elixir-ls [3]: https://github.com/JakeBecker/vscode-elixir-ls/blob/master/syntaxes/elixir.json Co-authored-by: Arctic Ice Studio <development@arcticicestudio.com> Resolves GH-165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #165
Improve Elixir support adding syntax highlight to atoms and module names using
vscode-elixir-lis
patterns.References:
https://github.com/JakeBecker/vscode-elixir-ls
https://github.com/JakeBecker/vscode-elixir-ls/blob/master/syntaxes/elixir.json