descriptionForeground workbench theme key
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the `descriptionForeground` workbench theme key that was introduced almost 2 years ago in microsoft/vscode@f450e0b1fe3 (1) for microsoft/vscode#26298 (2), but not mentioned in a changelog so there was no support for it in Nord. It now uses `nord4` with a opacity of 90% as color value (`#d8dee9e6`). References: (1) https://github.com/microsoft/vscode/blame/f450e0b1fe3ac26ce6bf8367ff1bd60fb1387a7d/src/vs/platform/theme/common/colorRegistry.ts#L154 (2) microsoft/vscode#26298 GH-160
svengreb
approved these changes
Oct 9, 2019
arcticicestudio
deleted the
feature/gh-160-descriptionforeground-workbench-key
branch
arcticicestudio
added a commit
that referenced
this pull request
Dec 23, 2019
Added the `descriptionForeground` workbench theme key that was introduced almost 2 years ago in microsoft/vscode@f450e0b1fe3 (1) for microsoft/vscode#26298 (2), but not mentioned in a changelog so there was no support for it in Nord. It now uses `nord4` with a opacity of 90% as color value (`#d8dee9e6`). References: (1) https://github.com/microsoft/vscode/blame/f450e0b1fe3ac26ce6bf8367ff1bd60fb1387a7d/src/vs/platform/theme/common/colorRegistry.ts#L154 (2) microsoft/vscode#26298 Resolves GH-160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #160
This PR adds the
descriptionForegroundworkbench theme key that was introduced almost 2 years ago in microsoft/vscode@f450e0b1fe3 for microsoft/vscode#26298, but not mentioned in a changelog so there was no support for it in Nord.It now uses
nord4with a opacity of 90% as color value (#d8dee9e6).